[vlc-commits] opengl: do not report interop fmt changes

[Romain Vimont]

vlc | branch: master | Romain Vimont <rom1v at videolabs.io> | Wed Jun 17 21:28:49 2020 +0200| [b79c2b224910d6987a3284ecaafeb4abb32a9a69] | committer: Alexandre Janniaux

opengl: do not report interop fmt changes

The interop implementations may edit their copy of input format, in
particular to handle RGB fallbacks.

These internal changes must not be reported to the core, otherwise it
would attempt to insert a converter.

Signed-off-by: Alexandre Janniaux <ajanni at videolabs.io>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b79c2b224910d6987a3284ecaafeb4abb32a9a69
---

 modules/video_output/opengl/vout_helper.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/modules/video_output/opengl/vout_helper.c b/modules/video_output/opengl/vout_helper.c
index a5a0af3d30..526edcb23f 100644
--- a/modules/video_output/opengl/vout_helper.c
+++ b/modules/video_output/opengl/vout_helper.c
@@ -178,12 +178,6 @@ vout_display_opengl_t *vout_display_opengl_New(video_format_t *fmt,
      && vout_display_opengl_SetViewpoint(vgl, viewpoint) != VLC_SUCCESS)
         goto delete_sub_renderer;
 
-    video_orientation_t orientation = fmt->orientation;
-    *fmt = vgl->interop->fmt;
-    /* The orientation is handled by the orientation matrix: from the core
-     * point of view, it does not change. */
-    fmt->orientation = orientation;
-
     if (subpicture_chromas) {
         *subpicture_chromas = gl_subpicture_chromas;
     }