[vlc-commits] opengl: renderer: avoid clearing on Open()

[Alexandre Janniaux]

vlc | branch: master | Alexandre Janniaux <ajanni at videolabs.io> | Sat Jun 20 11:23:44 2020 +0200| [4a61e894760b446d5ea63437b75101787b28b126] | committer: Alexandre Janniaux

opengl: renderer: avoid clearing on Open()

Ideally, the renderer should never clear at all, but clearing on Open()
is an unexpected drawing operation when initializing it.

It's important in particular on MacOSX in which the default framebuffer
is in a valid state only in drawing callbacks and Clear()-ing it leads
to invalid framebuffer operation errors in OpenGL.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=4a61e894760b446d5ea63437b75101787b28b126
---

 modules/video_output/opengl/renderer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/video_output/opengl/renderer.c b/modules/video_output/opengl/renderer.c
index 6f7d42ee7a..aa51f8b3a3 100644
--- a/modules/video_output/opengl/renderer.c
+++ b/modules/video_output/opengl/renderer.c
@@ -356,7 +356,6 @@ vlc_gl_renderer_New(vlc_gl_t *gl, const struct vlc_gl_api *api,
     vt->DepthMask(GL_FALSE);
     vt->Enable(GL_CULL_FACE);
     vt->ClearColor(0.0f, 0.0f, 0.0f, 1.0f);
-    vt->Clear(GL_COLOR_BUFFER_BIT);
 
     vt->GenBuffers(1, &renderer->vertex_buffer_object);
     vt->GenBuffers(1, &renderer->index_buffer_object);