[vlc-commits] macosx: fix float lower bound check

Lyndon Brown git at videolan.org
Sun Nov 15 19:22:25 CET 2020


vlc/vlc-3.0 | branch: master | Lyndon Brown <jnqnfe at gmail.com> | Sun Mar 31 07:34:10 2019 +0200| [1c729cb550d1270d3d6f218966c96722e5c7002a] | committer: David Fuhrmann

macosx: fix float lower bound check

needs to check -FLT_MAX not FLT_MIN, as explained in
c95d5fbea2122ac471f8aee86ee9f1cafeddeb00

(backport of 9f1c2f7aae1732bbf5374e3ade65a6ed14b0c966)
Signed-off-by: Steve Lhomme <robux4 at ycbcr.xyz>
Signed-off-by: David Fuhrmann <dfuhrmann at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=1c729cb550d1270d3d6f218966c96722e5c7002a
---

 modules/gui/macosx/prefs_widgets.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/gui/macosx/prefs_widgets.m b/modules/gui/macosx/prefs_widgets.m
index e77e39805b..2190684e2e 100644
--- a/modules/gui/macosx/prefs_widgets.m
+++ b/modules/gui/macosx/prefs_widgets.m
@@ -810,7 +810,7 @@ o_textfield = [[NSSecureTextField alloc] initWithFrame: s_rc];              \
                                                      withView: parentView];
             break;
         case CONFIG_ITEM_FLOAT:
-            if (_p_item->min.f > FLT_MIN && _p_item->max.f < FLT_MAX)
+            if (_p_item->min.f > -FLT_MAX && _p_item->max.f < FLT_MAX)
                 control = [[RangedFloatConfigControl alloc] initWithItem: _p_item withView: parentView];
             else
                 control = [[FloatConfigControl alloc] initWithItem: _p_item withView: parentView];



More information about the vlc-commits mailing list