[vlc-commits] input: Fix missing mutex unlock on error path

Hugo Beauzée-Luyssen git at videolan.org
Thu Nov 19 11:00:23 CET 2020


vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Tue Nov 10 16:39:38 2020 +0100| [88306b2b7c0909f656e81c8b5947c3ed58e2b5c5] | committer: Hugo Beauzée-Luyssen

input: Fix missing mutex unlock on error path

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=88306b2b7c0909f656e81c8b5947c3ed58e2b5c5
---

 src/input/input.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/input/input.c b/src/input/input.c
index e6a1e4a874..06b18e2f5c 100644
--- a/src/input/input.c
+++ b/src/input/input.c
@@ -3474,7 +3474,10 @@ int input_GetAttachments(input_thread_t *input,
 
     *attachments = vlc_alloc(attachments_count, sizeof(input_attachment_t*));
     if (!*attachments)
+    {
+        vlc_mutex_unlock(&priv->p_item->lock);
         return -1;
+    }
 
     for (int i = 0; i < attachments_count; i++)
         (*attachments)[i] = vlc_input_attachment_Hold(priv->attachment[i]);



More information about the vlc-commits mailing list