[vlc-commits] macosx: fix use-after-free / double-free

[Lyndon Brown]

vlc | branch: master | Lyndon Brown <jnqnfe at gmail.com> | Tue Apr  9 04:16:57 2019 +0100| [886824ab7797dd5dc7c165144251c78cc4caf0db] | committer: Felix Paul Kühne

macosx: fix use-after-free / double-free

Signed-off-by: Felix Paul Kühne <felix at feepk.net>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=886824ab7797dd5dc7c165144251c78cc4caf0db
---

 modules/gui/macosx/preferences/prefs_widgets.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/gui/macosx/preferences/prefs_widgets.m b/modules/gui/macosx/preferences/prefs_widgets.m
index d256052579..7dffab2899 100644
--- a/modules/gui/macosx/preferences/prefs_widgets.m
+++ b/modules/gui/macosx/preferences/prefs_widgets.m
@@ -1255,8 +1255,8 @@ o_textfield = [[NSSecureTextField alloc] initWithFrame: s_rc];              \
                     break;
                 }
             }
-            module_config_free(p_config);
         }
+        module_config_free(p_config);
     }
     module_list_free(p_list);