[vlc-commits] shine: fix close ordering

Rémi Denis-Courmont git at videolan.org
Mon Oct 12 20:29:24 CEST 2020


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon Oct 12 21:22:01 2020 +0300| [86b3c671aead2578d44bc03667f0af961623b121] | committer: Rémi Denis-Courmont

shine: fix close ordering

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=86b3c671aead2578d44bc03667f0af961623b121
---

 modules/codec/shine.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/modules/codec/shine.c b/modules/codec/shine.c
index e8fcc68f07..525d97427a 100644
--- a/modules/codec/shine.c
+++ b/modules/codec/shine.c
@@ -271,14 +271,13 @@ static void CloseEncoder( vlc_object_t *p_this )
 {
     encoder_sys_t *p_sys = ((encoder_t*)p_this)->p_sys;
 
-    atomic_store(&busy, false);
-
     /* TODO: we should send the last PCM block padded with 0
      * But we don't know if other blocks will come before it's too late */
     if( p_sys->i_buffer )
         free( p_sys->p_buffer );
 
     shine_close(p_sys->s);
+    atomic_store(&busy, false);
 
     block_FifoRelease( p_sys->p_fifo );
     free( p_sys );



More information about the vlc-commits mailing list