[vlc-commits] keystore: accept empty username

[Thomas Guillem]

vlc/vlc-3.0 | branch: master | Thomas Guillem <thomas at gllm.fr> | Tue Sep  1 10:57:29 2020 +0200| [e7854754d234e50b5f2b36d214f31e20ffbeb0da] | committer: Thomas Guillem

keystore: accept empty username

The http protocol accepts empty username. Other protocols may not accept it.
This will result on a fail of the login function, leaving the possibility to
try a new login.

Fixes #25074

(cherry picked from commit 384526b41285662944625bdd0b61c03868358279)
Signed-off-by: Thomas Guillem <thomas at gllm.fr>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=e7854754d234e50b5f2b36d214f31e20ffbeb0da
---

 src/misc/keystore.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/misc/keystore.c b/src/misc/keystore.c
index b21016c5f5..a002810174 100644
--- a/src/misc/keystore.c
+++ b/src/misc/keystore.c
@@ -191,8 +191,7 @@ find_closest_path(vlc_keystore_entry *p_entries, unsigned i_count,
 static bool
 is_credential_valid(vlc_credential *p_credential)
 {
-    if (p_credential->psz_username && *p_credential->psz_username != '\0'
-     && p_credential->psz_password)
+    if (p_credential->psz_username && p_credential->psz_password)
         return true;
     p_credential->psz_password = NULL;
     return false;