[vlc-commits] qt: remove general tooltop on module checkbox group

[Lyndon Brown]

vlc | branch: master | Lyndon Brown <jnqnfe at gmail.com> | Tue Apr  9 19:56:42 2019 +0100| [e85dd955278e08fbf309120f0a360b414f76815c] | committer: Jean-Baptiste Kempf

qt: remove general tooltop on module checkbox group

With module selection controls which feature a groupbox of module
checkboxes, if individual modules have their own longtext, that is
displayed in a tooltip when hovering on them; for all others, the help
text for the entire control (groupbox) gets displayed, which is just
confusing from a UX point of view.

This removes the general groupbox tooltip, thus fixing this.

It remains for the textbox portion of the control however, so hovering over
that still provides the helptext!

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e85dd955278e08fbf309120f0a360b414f76815c
---

 modules/gui/qt/dialogs/preferences/preferences_widgets.cpp | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/modules/gui/qt/dialogs/preferences/preferences_widgets.cpp b/modules/gui/qt/dialogs/preferences/preferences_widgets.cpp
index 53c05171e0..462d141400 100644
--- a/modules/gui/qt/dialogs/preferences/preferences_widgets.cpp
+++ b/modules/gui/qt/dialogs/preferences/preferences_widgets.cpp
@@ -693,15 +693,6 @@ void ModuleListConfigControl::finish( bool bycat )
         }
     }
     module_list_free( p_list );
-
-    if( p_item->psz_longtext )
-    {
-        QString tipText = qtr(p_item->psz_longtext);
-
-        text->setToolTip( formatTooltip(tipText) );
-        assert( groupBox );
-        groupBox->setToolTip( formatTooltip(tipText) );
-   }
 }
 
 QString ModuleListConfigControl::getValue() const