[vlc-commits] qml: fix binding loop detected warning in PlaylistToolbar

Fatih Uzunoglu git at videolan.org
Fri Apr 16 11:20:16 UTC 2021


vlc | branch: master | Fatih Uzunoglu <fuzun54 at outlook.com> | Mon Apr 12 00:45:26 2021 +0300| [552541ba7f8e91d3de14c0e0654bd4831380fe49] | committer: Pierre Lamot

qml: fix binding loop detected warning in PlaylistToolbar

fixes part of #25601

Signed-off-by: Pierre Lamot <pierre at videolabs.io>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=552541ba7f8e91d3de14c0e0654bd4831380fe49
---

 modules/gui/qt/playlist/qml/PlaylistToolbar.qml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/modules/gui/qt/playlist/qml/PlaylistToolbar.qml b/modules/gui/qt/playlist/qml/PlaylistToolbar.qml
index ca0f52418b..3c0a7201e4 100644
--- a/modules/gui/qt/playlist/qml/PlaylistToolbar.qml
+++ b/modules/gui/qt/playlist/qml/PlaylistToolbar.qml
@@ -34,7 +34,7 @@ RowLayout {
 
     Item {
         Layout.fillWidth: true
-        implicitHeight: childrenRect.height
+        implicitHeight: loop.height
 
         Widgets.IconToolButton {
             id: loop
@@ -54,7 +54,7 @@ RowLayout {
 
     Item {
         Layout.fillWidth: true
-        implicitHeight: childrenRect.height
+        implicitHeight: shuffle.height
 
         Widgets.IconToolButton {
             id: shuffle
@@ -71,7 +71,7 @@ RowLayout {
 
     Item {
         Layout.fillWidth: true
-        implicitHeight: childrenRect.height
+        implicitHeight: sort.height
 
         Widgets.SortControl {
             id: sort
@@ -117,7 +117,7 @@ RowLayout {
 
     Item {
         Layout.fillWidth: true
-        implicitHeight: childrenRect.height
+        implicitHeight: clear.height
 
         Widgets.IconToolButton {
             id: clear



More information about the vlc-commits mailing list