[vlc-commits] opengl: fix missing flag initialization

Romain Vimont git at videolan.org
Tue Apr 20 10:49:18 UTC 2021


vlc | branch: master | Romain Vimont <rom1v at videolabs.io> | Mon Apr 12 19:04:14 2021 +0200| [0b339ba2ece3dcb2cb90bce4674af295ccef9540] | committer: Alexandre Janniaux

opengl: fix missing flag initialization

The flag filter_planes was not explicitly initialized, and non-plane
filters assume that it is set to false by default.

It still worked because the filter happens to be initialized by calloc()
in the end, but we shouldn't rely on this detail (and the other fields
are also explicitly initialized).

Signed-off-by: Alexandre Janniaux <ajanni at videolabs.io>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0b339ba2ece3dcb2cb90bce4674af295ccef9540
---

 modules/video_output/opengl/filter.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/modules/video_output/opengl/filter.c b/modules/video_output/opengl/filter.c
index b7357c7b20..02ffc7d75d 100644
--- a/modules/video_output/opengl/filter.c
+++ b/modules/video_output/opengl/filter.c
@@ -49,6 +49,7 @@ vlc_gl_filter_New(vlc_object_t *parent, const struct vlc_gl_api *api)
 
     struct vlc_gl_filter *filter = &priv->filter;
     filter->api = api;
+    filter->config.filter_planes = false;
     filter->config.blend = false;
     filter->config.msaa_level = 0;
     filter->ops = NULL;



More information about the vlc-commits mailing list