[vlc-commits] [Git][videolan/vlc][master] qml/MainDisplay: Fix keyboard focus loss when clearing the 'localMenuDelegate'

[Hugo Beauzée-Luyssen (@chouquette)]

Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC


Commits:
74c682d7 by Benjamin Arnaud at 2021-08-28T16:46:04+00:00
qml/MainDisplay: Fix keyboard focus loss when clearing the 'localMenuDelegate'

The previous implementation made us lose the keyboard focus each time we set 'localMenuDelegate' to null.

- - - - -


2 changed files:

- modules/gui/qt/maininterface/qml/BannerSources.qml
- modules/gui/qt/maininterface/qml/MainDisplay.qml


Changes:

=====================================
modules/gui/qt/maininterface/qml/BannerSources.qml
=====================================
@@ -340,6 +340,7 @@ FocusScope {
                         onVisibleChanged: {
                             //reset the focus on the global group when the local group is hidden,
                             //this avoids losing the focus if the subview changes
+                            // FIXME: This block needs refactor for keyboard focus.
                             if (!visible && localMenuGroup.focus) {
                                 localMenuGroup.focus = false
                                 globalMenuGroup.focus = true


=====================================
modules/gui/qt/maininterface/qml/MainDisplay.qml
=====================================
@@ -197,7 +197,6 @@ FocusScope {
                     model: root.tabModel
 
                     onItemClicked: {
-                        sourcesBanner.localMenuDelegate = null
                         var name = root.tabModel.get(index).name
                         selectedIndex = index
                         history.push(["mc", name])



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/74c682d76a6141f7430e95eecac0ea6c43f032a8

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/74c682d76a6141f7430e95eecac0ea6c43f032a8
You're receiving this email because of your account on code.videolan.org.