[vlc-commits] qml: remove unnecessary property binding

Fatih Uzunoglu git at videolan.org
Tue Jan 12 13:20:37 UTC 2021


vlc | branch: master | Fatih Uzunoglu <fuzun54 at outlook.com> | Fri Jan  8 00:36:39 2021 +0300| [0bfd7c139b4d4a698dca63d418c3d9957efdeeda] | committer: Pierre Lamot

qml: remove unnecessary property binding

modelCount is already bound in the parent item (KeyNavigableListView)

Signed-off-by: Pierre Lamot <pierre at videolabs.io>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0bfd7c139b4d4a698dca63d418c3d9957efdeeda
---

 modules/gui/qt/playlist/qml/PlaylistListView.qml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/modules/gui/qt/playlist/qml/PlaylistListView.qml b/modules/gui/qt/playlist/qml/PlaylistListView.qml
index e43f4d0ace..199b85f4c8 100644
--- a/modules/gui/qt/playlist/qml/PlaylistListView.qml
+++ b/modules/gui/qt/playlist/qml/PlaylistListView.qml
@@ -268,7 +268,6 @@ Widgets.NavigableFocusScope {
                 model: PlaylistListModel {
                     playlistId: mainctx.playlist
                 }
-                modelCount: root.model.count
 
                 fadeColor: parentRect.color
 
@@ -287,9 +286,8 @@ Widgets.NavigableFocusScope {
                     }
                     onSelectedCountChanged: {
                         var selectedIndexes = root.model.getSelection()
-                        var modelCount = root.model.count
 
-                        if (modelCount === 0 || selectedIndexes.length === 0)
+                        if (listView.modelCount === 0 || selectedIndexes.length === 0)
                             return
 
                         var bottomItemIndex = listView.listView.indexAt(listView.listView.contentX, (listView.listView.contentY + listView.height) - 2)



More information about the vlc-commits mailing list