[vlc-commits] android: utils: fix double free

[Alexandre Janniaux]

vlc | branch: master | Alexandre Janniaux <ajanni at videolabs.io> | Wed Jan 13 12:07:14 2021 +0100| [26bed35064c45a9e607059ba2ee660876ec1a28b] | committer: Alexandre Janniaux

android: utils: fix double free

The SurfaceTexture class is freed multiple times whenever the
libvlc_media_player is restarted.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=26bed35064c45a9e607059ba2ee660876ec1a28b
---

 modules/video_output/android/utils.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/modules/video_output/android/utils.c b/modules/video_output/android/utils.c
index 1cd7469cf2..6e8a6f22b0 100644
--- a/modules/video_output/android/utils.c
+++ b/modules/video_output/android/utils.c
@@ -893,12 +893,6 @@ AWindowHandler_destroy(AWindowHandler *p_awh)
 
     if (p_env)
     {
-        if (jfields.SurfaceTexture.clazz)
-            (*p_env)->DeleteGlobalRef(p_env, jfields.SurfaceTexture.clazz);
-
-        if (jfields.Surface.clazz)
-            (*p_env)->DeleteGlobalRef(p_env, jfields.Surface.clazz);
-
         JNI_ANWCALL(CallVoidMethod, unregisterNative);
         AWindowHandler_releaseANativeWindowEnv(p_awh, p_env, AWindow_Video);
         AWindowHandler_releaseANativeWindowEnv(p_awh, p_env, AWindow_Subtitles);