[vlc-commits] fetcher: fix use-after-free on error

[Romain Vimont]

vlc | branch: master | Romain Vimont <rom1v at videolabs.io> | Sun Jan 24 18:33:09 2021 +0100| [62233f501867c1a7ab44d923679c01cb56748fd1] | committer: Alexandre Janniaux

fetcher: fix use-after-free on error

A "goto out;" was left on the error branch, causing the task to be used-
after-free.

Signed-off-by: Alexandre Janniaux <ajanni at videolabs.io>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=62233f501867c1a7ab44d923679c01cb56748fd1
---

 src/preparser/fetcher.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/preparser/fetcher.c b/src/preparser/fetcher.c
index 7616078ff8..6fe6036df4 100644
--- a/src/preparser/fetcher.c
+++ b/src/preparser/fetcher.c
@@ -375,7 +375,6 @@ error:
     NotifyArtFetchEnded(task, false);
     FetcherRemoveTask(fetcher, task);
     TaskDelete(task);
-    goto out;
 }
 
 static void RunSearchLocal(void *userdata)