[vlc-commits] [Git][videolan/vlc][master] qt: remove unnecessary item skipping

Romain Vimont (@rom1v) gitlab at videolan.org
Thu Jul 1 15:35:36 UTC 2021



Romain Vimont pushed to branch master at VideoLAN / VLC


Commits:
1fb307f7 by Lyndon Brown at 2021-07-01T14:42:09+00:00
qt: remove unnecessary item skipping

`module_config_get()` already filters these out so this is redundant.

- - - - -


1 changed file:

- modules/gui/qt/dialogs/preferences/complete_preferences.cpp


Changes:

=====================================
modules/gui/qt/dialogs/preferences/complete_preferences.cpp
=====================================
@@ -570,9 +570,6 @@ bool PrefsItemData::contains( const QString &text, Qt::CaseSensitivity cs )
             continue;
         }
 
-        /* private options (hidden from GUI but not help output) are not relevant */
-        if( p_item->b_internal ) continue;
-
         /* cat-hint items are not relevant, they are an alternate set of headings for help output */
         if( p_item->i_type == CONFIG_HINT_CATEGORY ) continue;
 
@@ -686,7 +683,6 @@ AdvPrefsPanel::AdvPrefsPanel( qt_intf_t *_p_intf, QWidget *_parent,
             ( p_item->i_type == CONFIG_CATEGORY ||
               p_item->i_type == CONFIG_SUBCATEGORY ) )
             break;
-        if( p_item->b_internal ) continue;
 
         if( p_item->i_type == CONFIG_SECTION )
         {



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/1fb307f7dcddd3dd2887aaa6eeb1deda904ddba3

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/1fb307f7dcddd3dd2887aaa6eeb1deda904ddba3
You're receiving this email because of your account on code.videolan.org.




More information about the vlc-commits mailing list