[vlc-commits] [Git][videolan/vlc][master] Revert "es_out: reset main clocks when terminating"

[Thomas Guillem (@tguillem)]

Thomas Guillem pushed to branch master at VideoLAN / VLC


Commits:
9768497d by Thomas Guillem at 2021-07-16T16:22:06+02:00
Revert "es_out: reset main clocks when terminating"

This reverts commit 36596846205e64cb0c529586c50a4f3789a5c206.

This was a really bad idea. There was 50/50 chance to improve close
speed or to make it worse. Indeed, resetting the clock means that the
next output update create its own reference point. That point has the
same chance to be after or before the previous point.

- - - - -


1 changed file:

- src/input/es_out.c


Changes:

=====================================
src/input/es_out.c
=====================================
@@ -3636,18 +3636,6 @@ static int EsOutVaPrivControlLocked( es_out_t *out, int query, va_list args )
         p_sys->b_active = i_mode != ES_OUT_MODE_NONE;
         p_sys->i_mode = i_mode;
 
-        if( i_mode == ES_OUT_MODE_NONE )
-        {
-            /* Reset main clocks before unselecting every ESes. This will speed
-             * up audio and video output termination. Indeed, they won't wait
-             * for a specific PTS conversion. This may also unblock outputs in
-             * case of a corrupted sample with a PTS very far in the future.
-             * */
-            es_out_pgrm_t *pgrm;
-            vlc_list_foreach(pgrm, &p_sys->programs, node)
-                vlc_clock_main_Reset(pgrm->p_main_clock);
-        }
-
         /* Reapply policy mode */
         es_out_id_t *es;
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/9768497d03f7172623a204199843b1b73fb7d2e8

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/9768497d03f7172623a204199843b1b73fb7d2e8
You're receiving this email because of your account on code.videolan.org.