[vlc-commits] macosx: Workaround crash in PXSourceList dealloc

[David Fuhrmann]

vlc/vlc-3.0 | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Tue Jun  1 17:54:45 2021 +0200| [bb7022aed9b88cd519848de19d1cb6ba3795d1b2] | committer: David Fuhrmann

macosx: Workaround crash in PXSourceList dealloc

[super setDataSource] crashes on macOS 10.11 until 10.13.
The code in question should not be needed (the recieving
properties are weak in new macOS frameworks).
Also whole deallocation of this object is not consistent.
Therefore remove the code in question.

Closes videolan/vlc#21267

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=bb7022aed9b88cd519848de19d1cb6ba3795d1b2
---

 modules/gui/macosx/PXSourceList/PXSourceList.m | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/modules/gui/macosx/PXSourceList/PXSourceList.m b/modules/gui/macosx/PXSourceList/PXSourceList.m
index fd7f74b419..ec43c6aa48 100755
--- a/modules/gui/macosx/PXSourceList/PXSourceList.m
+++ b/modules/gui/macosx/PXSourceList/PXSourceList.m
@@ -67,14 +67,6 @@ NSString * const PXSLDeleteKeyPressedOnRowsNotification = @"PXSourceListDeleteKe
     _delegateDataSourceProxy = [[PXSourceListDelegateDataSourceProxy alloc] initWithSourceList:self];
 }
 
-- (void)dealloc
-{
-    _delegateDataSourceProxy = nil;
-    //Remove ourselves as the delegate and data source to be safe
-    [super setDataSource:nil];
-    [super setDelegate:nil];
-}
-
 
 #pragma mark -
 #pragma mark Custom Accessors