[vlc-commits] [Git][videolan/vlc][master] configure: remove redundant PIE flags for sanitizers

[Hugo Beauzée-Luyssen]

Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC


Commits:
8d47e5a8 by Marvin Scholz at 2021-06-04T07:12:50+00:00
configure: remove redundant PIE flags for sanitizers

As per the Clang documentation, some sanitizers
only work with position independent executables,
so it is implied already by the sanitizer flag:

> Non-position-independent executables are not supported.
> Therefore, the fsanitize=thread flag will cause Clang
> to act as though the -fPIE flag had been supplied if
> compiling without -fPIC, and as though the -pie flag
> had been supplied if linking an executable.

https://clang.llvm.org/docs/ThreadSanitizer.html#limitations

- - - - -


1 changed file:

- configure.ac


Changes:

=====================================
configure.ac
=====================================
@@ -1183,14 +1183,6 @@ AS_VAR_IF(with_sanitizer, no, [], [
        AX_APPEND_COMPILE_FLAGS([-fsanitize-address-use-after-scope -fno-omit-frame-pointer -fsanitize=pointer-compare -fsanitize=pointer-subtract])
        AX_APPEND_COMPILE_FLAGS([-fsanitize-address-use-after-scope -fno-omit-frame-pointer -fsanitize=pointer-compare -fsanitize=pointer-subtract], [CXXFLAGS])
     ])
-    AS_IF([test -z "${with_sanitizer##*memory*}" ], [
-        AX_APPEND_COMPILE_FLAGS([-fPIE -pie])
-        AX_APPEND_COMPILE_FLAGS([-fPIE -pie], [CXXFLAGS])
-    ])
-    AS_IF([test -z "${with_sanitizer##*thread*}" ], [
-        AX_APPEND_COMPILE_FLAGS([-fPIE -pie])
-        AX_APPEND_COMPILE_FLAGS([-fPIE -pie], [CXXFLAGS])
-    ])
 ])
 
 dnl



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/8d47e5a8bad83ba567668f9f2c37a16b05e19faf

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/8d47e5a8bad83ba567668f9f2c37a16b05e19faf
You're receiving this email because of your account on code.videolan.org.