[vlc-commits] [Git][videolan/vlc][3.0.x] 4 commits: qt: hide all empty groupboxes

[Jean-Baptiste Kempf]

Jean-Baptiste Kempf pushed to branch 3.0.x at VideoLAN / VLC


Commits:
de17adf1 by Lyndon Brown at 2021-06-16T04:52:35+00:00
qt: hide all empty groupboxes

if a panel only has one groupbox and it is empty, it was hidden, but
otherwise they were shown; this was surely a bug, and at any rate is
undesirably messy. all empty groupboxes are now hidden.

an example case: this fixes the empty "Performance options" groupbox (on
my system) under the top-level "Advanced" tree node in the advanced
preferences view, which happens to be very visible as the first panel
shown when switching to advanced mode.

(cherry picked from commit 9214590343c9b8d55a88efaa3ca1f3c16109d553)

- - - - -
6a153029 by Lyndon Brown at 2021-06-16T04:52:35+00:00
qt: remove general tooltop on module checkbox group

With module selection controls which feature a groupbox of module
checkboxes, if individual modules have their own longtext, that is
displayed in a tooltip when hovering on them; for all others, the help
text for the entire control (groupbox) gets displayed, which is just
confusing from a UX point of view.

This removes the general groupbox tooltip, thus fixing this.

It remains for the textbox portion of the control however, so hovering over
that still provides the helptext!

(cherry picked from commit e85dd955278e08fbf309120f0a360b414f76815c)

- - - - -
dba1fa4e by Lyndon Brown at 2021-06-16T04:52:35+00:00
qt: fix subtitle tabstop ordering

(cherry picked from commit b407307b78575f90a64c4f2fb1103140f3458f16)

- - - - -
c76cb856 by Lyndon Brown at 2021-06-16T04:52:35+00:00
qt: (hotkeys) remove incorrect hotkey table label tooltip

the item pointer provided to the constructor is that of a single hotkey
config item. using the longtext from this item in a tooltip on the label
for the entire hotkey table makes zero sense, so let's remove it.

 - for the table shown in the simple view, the "key-play" option was
   arbitrarily used for this.
 - for the table shown in the advanced view, the text from the first
   hotkey config item encountered was used.

(cherry picked from commit b0385e9324a0f342e51bf5b61a50904adb4d47dd)

- - - - -


3 changed files:

- modules/gui/qt/components/complete_preferences.cpp
- modules/gui/qt/components/preferences_widgets.cpp
- modules/gui/qt/ui/sprefs_subtitles.ui


Changes:

=====================================
modules/gui/qt/components/complete_preferences.cpp
=====================================
@@ -680,13 +680,14 @@ AdvPrefsPanel::AdvPrefsPanel( intf_thread_t *_p_intf, QWidget *_parent,
 
         if( p_item->i_type == CONFIG_SECTION )
         {
-            if( box )
+            if( box && i_boxline > 0 )
             {
                 box->setLayout( boxlayout );
                 box->show();
                 layout->addWidget( box, i_line, 0, 1, -1 );
                 i_line++;
             }
+            i_boxline = 0;
             box = new QGroupBox( qtr( p_item->psz_text ), this );
             box->hide();
             boxlayout = new QGridLayout();


=====================================
modules/gui/qt/components/preferences_widgets.cpp
=====================================
@@ -703,15 +703,6 @@ void ModuleListConfigControl::finish( bool bycat )
         }
     }
     module_list_free( p_list );
-
-    if( p_item->psz_longtext )
-    {
-        QString tipText = qtr(p_item->psz_longtext);
-
-        text->setToolTip( formatTooltip(tipText) );
-        assert( groupBox );
-        groupBox->setToolTip( formatTooltip(tipText) );
-   }
 }
 
 QString ModuleListConfigControl::getValue() const
@@ -1196,9 +1187,6 @@ void KeySelectorControl::buildAppHotkeysList( QWidget *rootWidget )
 
 void KeySelectorControl::finish()
 {
-    if( label && p_item->psz_longtext )
-        label->setToolTip( formatTooltip( qtr( p_item->psz_longtext ) ) );
-
     /* Fill the table */
 
     /* Get the main Module */


=====================================
modules/gui/qt/ui/sprefs_subtitles.ui
=====================================
@@ -335,6 +335,7 @@
   <tabstop>OSDBox</tabstop>
   <tabstop>OSDTitleBox</tabstop>
   <tabstop>OSDTitlePos</tabstop>
+  <tabstop>spuActiveBox</tabstop>
   <tabstop>preferredLanguage</tabstop>
   <tabstop>encoding</tabstop>
   <tabstop>font</tabstop>
@@ -343,6 +344,7 @@
   <tabstop>effect</tabstop>
   <tabstop>outlineColor</tabstop>
   <tabstop>shadowCheck</tabstop>
+  <tabstop>backgroundCheck</tabstop>
   <tabstop>subsPosition</tabstop>
  </tabstops>
  <resources/>



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/90dc0b2e06317dad5acad2b480ce5f6d80815bea...c76cb856732de985a0701bcefe88037c3822a92b

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/90dc0b2e06317dad5acad2b480ce5f6d80815bea...c76cb856732de985a0701bcefe88037c3822a92b
You're receiving this email because of your account on code.videolan.org.