[vlc-commits] [Git][videolan/vlc][master] access: imem: Remove error logs confusing libvlc users

[Hugo Beauzée-Luyssen]

Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC


Commits:
08214798 by Martin Finkel at 2021-05-07T12:26:00+00:00
access: imem: Remove error logs confusing libvlc users

libvlc_media_new_callbacks does not set imem-get and imem-release.
Because of this, the following logs
imem Error: Invalid get/release function pointers
are confusing users. This commit aligns behavior with imem-access.c
which also returns VLC_EGENERIC silently for missing read_cb.

- - - - -


1 changed file:

- modules/access/imem.c


Changes:

=====================================
modules/access/imem.c
=====================================
@@ -255,7 +255,6 @@ static int OpenCommon(vlc_object_t *object, imem_sys_t **sys_ptr, const char *ps
     free(tmp);
 
     if (!sys->source.get || !sys->source.release) {
-        msg_Err(object, "Invalid get/release function pointers");
         return VLC_EGENERIC;
     }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0821479844121f5fcfa6961bb5f69c3107c667e2

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0821479844121f5fcfa6961bb5f69c3107c667e2
You're receiving this email because of your account on code.videolan.org.