[vlc-commits] [Git][videolan/vlc][master] codec: twolame: return VLC_EGENERIC

[Hugo Beauzée-Luyssen (@chouquette)]

Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC


Commits:
988aa5b0 by Alexandre Janniaux at 2021-10-08T15:25:58+00:00
codec: twolame: return VLC_EGENERIC

...instead of -VLC_EGENERIC, leading to an overflow.

../../modules/codec/twolame.c: In function ‘OpenEncoder’:
../../modules/codec/twolame.c:236:16: warning: integer overflow in expression ‘-2147483648’ of type ‘int’ results in ‘-2147483648’ [-Woverflow]
  236 |         return -VLC_EGENERIC;
      |                ^

- - - - -


1 changed file:

- modules/codec/twolame.c


Changes:

=====================================
modules/codec/twolame.c
=====================================
@@ -233,7 +233,7 @@ static int OpenEncoder( vlc_object_t *p_this )
     if ( twolame_init_params( p_sys->p_twolame ) )
     {
         msg_Err( p_enc, "twolame initialization failed" );
-        return -VLC_EGENERIC;
+        return VLC_EGENERIC;
     }
 
     p_enc->pf_encode_audio = Encode;



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/988aa5b02183f1c8c7431d1eadba6ceee263c0be

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/988aa5b02183f1c8c7431d1eadba6ceee263c0be
You're receiving this email because of your account on code.videolan.org.