[vlc-commits] [Git][videolan/vlc][master] 2 commits: VLCCVOpenGLProvider: synchronize rendering to buffer

Jean-Baptiste Kempf (@jbk) gitlab at videolan.org
Mon Oct 11 17:22:50 UTC 2021



Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
9bb1eed3 by Alexandre Janniaux at 2021-10-11T16:59:32+00:00
VLCCVOpenGLProvider: synchronize rendering to buffer

Before tvOS 15.x, the synchronization was not necessary, but now it
would create artifacts on screen, as if the frames are not in the
correct order.

Until a proper synchronization mechanism is in place, force to
synchronize into the texture.

- - - - -
38dfc030 by Alexandre Janniaux at 2021-10-11T16:59:32+00:00
VLCCVOpenGLProvider: update buffer count to 3

Otherwise, it leads to a deadlock on tvOS 15.x.

- - - - -


1 changed file:

- modules/video_output/apple/VLCCVOpenGLProvider.m


Changes:

=====================================
modules/video_output/apple/VLCCVOpenGLProvider.m
=====================================
@@ -50,7 +50,7 @@
 #import "../codec/vt_utils.h"
 #import "../video_output/opengl/vout_helper.h"
 
-#define BUFFER_COUNT 2
+#define BUFFER_COUNT 3
 
 struct vlc_cvbuffer {
     CVPixelBufferRef cvpx;
@@ -411,6 +411,7 @@ static void FreeCVBuffer(picture_t *picture)
 
     _currentPicture = next_picture;
     // TODO: rebind at makeCurrent instead, if not binded?
+    glFinish();
     glBindFramebuffer(GL_FRAMEBUFFER, buffer->fbo);
 
     [self releaseCurrent];



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/afc12fe093739475ba2829a5bf239dde614417b3...38dfc030e595129856b0ec10febd00fb5983fc6e

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/afc12fe093739475ba2829a5bf239dde614417b3...38dfc030e595129856b0ec10febd00fb5983fc6e
You're receiving this email because of your account on code.videolan.org.




More information about the vlc-commits mailing list