[vlc-commits] [Git][videolan/vlc][master] Revert "win32: thread: ensure all thread variables from VLC have been deleted"

Hugo Beauzée-Luyssen (@chouquette) gitlab at videolan.org
Thu Oct 21 13:47:16 UTC 2021



Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC


Commits:
4e39cf0e by Steve Lhomme at 2021-10-21T13:21:24+00:00
Revert "win32: thread: ensure all thread variables from VLC have been deleted"

We can't really expect the process using libvlc to always exit properly. We
don't even do in VLC. So we should not assert when it does (harmless in release
builds).

This reverts commit 5f1dd4cabd3805bc03b44c5187c8b31cc6eca187.

Fixes #26205

- - - - -


1 changed file:

- src/win32/thread.c


Changes:

=====================================
src/win32/thread.c
=====================================
@@ -791,11 +791,6 @@ BOOL WINAPI DllMain (HANDLE hinstDll, DWORD fdwReason, LPVOID lpvReserved)
             break;
         }
 
-        case DLL_PROCESS_DETACH:
-            // all thread vars should have been deleted
-            assert(vlc_threadvar_last == NULL);
-            break;
-
         case DLL_THREAD_DETACH:
             vlc_threadvars_cleanup();
             break;



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/4e39cf0e71a3140e8febc8454c79f794b16e412b

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/4e39cf0e71a3140e8febc8454c79f794b16e412b
You're receiving this email because of your account on code.videolan.org.




More information about the vlc-commits mailing list