[vlc-commits] [Git][videolan/vlc][master] 2 commits: qml: fix LocalTabar binding to the current view

[Hugo Beauzée-Luyssen (@chouquette)]

Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC


Commits:
18649171 by Pierre Lamot at 2021-09-18T14:29:36+00:00
qml: fix LocalTabar binding to the current view

- - - - -
285ea796 by Pierre Lamot at 2021-09-18T14:29:36+00:00
qml: fix binding loop on focus in BannerSource

- - - - -


2 changed files:

- modules/gui/qt/maininterface/qml/BannerSources.qml
- modules/gui/qt/widgets/qml/LocalTabBar.qml


Changes:

=====================================
modules/gui/qt/maininterface/qml/BannerSources.qml
=====================================
@@ -339,7 +339,7 @@ FocusScope {
                         Loader {
                             id: localMenuGroup
 
-                            focus: !!item && item.focus && item.visible
+                            focus: true
                             visible: !!item
                             enabled: status === Loader.Ready
                             y: status === Loader.Ready ? (VLCStyle.localToolbar_height - item.height) / 2 : 0


=====================================
modules/gui/qt/widgets/qml/LocalTabBar.qml
=====================================
@@ -22,7 +22,7 @@ import "qrc:///style/"
 NavigableRow {
     id: row
 
-    property string currentView
+    property var currentView
     signal clicked(int index)
 
     height: VLCStyle.localToolbar_height
@@ -30,7 +30,7 @@ NavigableRow {
 
     delegate: BannerTabButton {
         text: model.displayText
-        selected: model.name === row.currentView
+        selected: model.name === row.currentView.name
         showCurrentIndicator: false
         height: VLCStyle.localToolbar_height
         color: VLCStyle.colors.lowerBanner



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/8cb3f81422c566ea738200f26d2c0c70bde8f9ed...285ea79612d956c4a7fcb882bc80f85467e83e1c

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/8cb3f81422c566ea738200f26d2c0c70bde8f9ed...285ea79612d956c4a7fcb882bc80f85467e83e1c
You're receiving this email because of your account on code.videolan.org.