[vlc-commits] [Git][videolan/vlc][master] 2 commits: qml: fix warnings in SearBox

[Hugo Beauzée-Luyssen (@chouquette)]

Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC


Commits:
83f76de7 by Pierre Lamot at 2021-09-19T10:05:14+00:00
qml: fix warnings in SearBox

- - - - -
3a298145 by Pierre Lamot at 2021-09-19T10:05:14+00:00
qml: searchbox textfield should be hidden when invisible

- - - - -


2 changed files:

- modules/gui/qt/maininterface/qml/BannerSources.qml
- modules/gui/qt/widgets/qml/SearchBox.qml


Changes:

=====================================
modules/gui/qt/maininterface/qml/BannerSources.qml
=====================================
@@ -60,7 +60,7 @@ FocusScope {
     }
 
     Binding {
-        target: contentModel
+        target: !!contentModel ? contentModel : null
         property: "searchPattern"
         value: searchBox.searchPattern
         when: !!contentModel


=====================================
modules/gui/qt/widgets/qml/SearchBox.qml
=====================================
@@ -64,6 +64,9 @@ FocusScope {
         duration: VLCStyle.duration_faster
         to: VLCStyle.widthSearchInput
         easing.type: Easing.InSine
+        onStarted: {
+            searchBoxRect.visible = true
+        }
     }
 
     SmoothedAnimation {
@@ -73,6 +76,9 @@ FocusScope {
         duration: VLCStyle.duration_faster
         to: 0
         easing.type: Easing.OutSine
+        onStopped: {
+            searchBoxRect.visible = false
+        }
     }
 
 
@@ -95,7 +101,7 @@ FocusScope {
             }
 
             Navigation.parentItem: root
-            Navigation.rightItem: _expanded ? searchBox : nullptr
+            Navigation.rightItem: _expanded ? searchBox : null
             Keys.priority: Keys.AfterItem
             Keys.onPressed: Navigation.defaultKeyAction(event)
         }
@@ -105,6 +111,7 @@ FocusScope {
             color: VLCStyle.colors.button
 
             anchors.verticalCenter: parent.verticalCenter
+            visible: false
 
             width: 0
             implicitHeight: searchBox.height



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/7c569348f90116de6cd81d47d4de163f9d67ae7a...3a298145bc80e4b91b47f6d8178a97321bf7419d

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/7c569348f90116de6cd81d47d4de163f9d67ae7a...3a298145bc80e4b91b47f6d8178a97321bf7419d
You're receiving this email because of your account on code.videolan.org.