[vlc-commits] [Git][videolan/vlc][master] 4 commits: qml/PlaylistListView: add bottom margin to header

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
449ae246 by Prince Gupta at 2021-09-26T15:18:56+00:00
qml/PlaylistListView: add bottom margin to header

- - - - -
48f87f14 by Prince Gupta at 2021-09-26T15:18:56+00:00
qml/PlaylistListView: set mipmap for artwork

- - - - -
1f87ae83 by Prince Gupta at 2021-09-26T15:18:56+00:00
qml: correctly access property

fixes warning i.e cannot read property 'width' of null

- - - - -
ce55b208 by Prince Gupta at 2021-09-26T15:18:56+00:00
qml: fix mute setting resetting when switching player view

- - - - -


3 changed files:

- modules/gui/qt/player/qml/controlbarcontrols/VolumeWidget.qml
- modules/gui/qt/playlist/qml/PlaylistDelegate.qml
- modules/gui/qt/playlist/qml/PlaylistListView.qml


Changes:

=====================================
modules/gui/qt/player/qml/controlbarcontrols/VolumeWidget.qml
=====================================
@@ -161,11 +161,12 @@ FocusScope{
                 if (paintOnly)
                     return
 
-                if (player.muted)
-                    player.muted = false
+                if (!volControl._inhibitPlayerVolumeUpdate) {
+                    if (player.muted)
+                        player.muted = false
 
-                if (!volControl._inhibitPlayerVolumeUpdate)
                     player.volume = volControl.value
+                }
             }
 
             Loader {


=====================================
modules/gui/qt/playlist/qml/PlaylistDelegate.qml
=====================================
@@ -227,6 +227,8 @@ Control {
 
                     Image {
                         id: artwork
+
+                        mipmap: true
                         anchors.fill: parent
                         fillMode: Image.PreserveAspectFit
                         source: (model.artwork && model.artwork.toString()) ? model.artwork : VLCStyle.noArtCover


=====================================
modules/gui/qt/playlist/qml/PlaylistListView.qml
=====================================
@@ -267,6 +267,7 @@ Control {
             visible: model.count !== 0
 
             Layout.topMargin: VLCStyle.margin_normal
+            Layout.bottomMargin: VLCStyle.margin_xxsmall
             Layout.leftMargin: VLCStyle.margin_normal
             Layout.rightMargin: listView.scrollBarWidth
 
@@ -475,7 +476,7 @@ Control {
                 // Instead of property forwarding, PlaylistDelegate is tightly coupled with PlaylistlistView
                 // since PlaylistDelegate is expected to be used only within PlaylistlistView
 
-                width: parent.width
+                width: listView.width
             }
 
             add: Transition {



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/921c02ce9cdc36770ff68016d458de5193495b73...ce55b2082a7b6232531acada73c6857b4fba5ef3

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/921c02ce9cdc36770ff68016d458de5193495b73...ce55b2082a7b6232531acada73c6857b4fba5ef3
You're receiving this email because of your account on code.videolan.org.