[vlc-commits] [Git][videolan/vlc][master] vlc_fifo: rename `_Release` to `_Delete`

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
36ca47ff by Alaric Senat at 2022-04-02T13:48:38+00:00
vlc_fifo: rename `_Release` to `_Delete`

"Release" usually imply that the object is refcounted in recents VLC
naming conventions. "Delete" or "Destroy" is more common and less
misleading for non-shared objects such as `vlc_fifo_t`.

- - - - -


4 changed files:

- include/vlc_block.h
- include/vlc_frame.h
- src/libvlccore.sym
- src/misc/fifo.c


Changes:

=====================================
include/vlc_block.h
=====================================
@@ -102,7 +102,7 @@
 
 #define block_FifoPut vlc_fifo_Put
 #define block_FifoNew vlc_fifo_New
-#define block_FifoRelease vlc_fifo_Release
+#define block_FifoRelease vlc_fifo_Delete
 #define block_FifoSize vlc_fifo_Size
 #define block_FifoGet vlc_fifo_Get
 #define block_FifoCount vlc_fifo_Count


=====================================
include/vlc_frame.h
=====================================
@@ -563,20 +563,20 @@ static inline vlc_frame_t *vlc_frame_ChainGather( vlc_frame_t *p_list )
  * Creates a thread-safe FIFO queue of blocks.
  *
  * See also vlc_fifo_Put() and vlc_fifo_Get().
- * The created queue must be released with vlc_fifo_Release().
+ * The created queue must be deleted with vlc_fifo_Delete().
  *
  * @return the FIFO or NULL on memory error
  */
 VLC_API vlc_fifo_t *vlc_fifo_New(void) VLC_USED VLC_MALLOC;
 
 /**
- * Destroys a FIFO created by vlc_fifo_New().
+ * Delete a FIFO created by vlc_fifo_New().
  *
- * @note Any queued blocks are also destroyed.
+ * @note Any queued blocks are also deleted.
  * @warning No other threads may be using the FIFO when this function is
  * called. Otherwise, undefined behaviour will occur.
  */
-VLC_API void vlc_fifo_Release(vlc_fifo_t *);
+VLC_API void vlc_fifo_Delete(vlc_fifo_t *);
 
 /**
  * Dequeue the first block from the FIFO. If necessary, wait until there is


=====================================
src/libvlccore.sym
=====================================
@@ -42,7 +42,7 @@ vlc_audio_meter_Process
 vlc_audio_meter_Flush
 vlc_fifo_Get
 vlc_fifo_New
-vlc_fifo_Release
+vlc_fifo_Delete
 vlc_fifo_Show
 vlc_frame_Alloc
 vlc_frame_AttachAncillary


=====================================
src/misc/fifo.c
=====================================
@@ -100,7 +100,7 @@ block_fifo_t *vlc_fifo_New( void )
     return p_fifo;
 }
 
-void vlc_fifo_Release( block_fifo_t *p_fifo )
+void vlc_fifo_Delete( block_fifo_t *p_fifo )
 {
     vlc_fifo_Empty(p_fifo);
     free( p_fifo );



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/36ca47ff5772a104e5ee057a7956353ad08b9d59

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/36ca47ff5772a104e5ee057a7956353ad08b9d59
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance