[vlc-commits] [Git][videolan/vlc][master] arm: neon: return VLC_SUCCESS for packed to planar

[Hugo Beauzée-Luyssen (@chouquette)]

Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC


Commits:
6815627a by Johannes Kauffmann at 2022-08-15T13:15:12+00:00
arm: neon: return VLC_SUCCESS for packed to planar

All packed cases (UYVY/VYUY/YVYU/YUYV) would eventually fall through to
the default case, and thus return VLC_EGENERIC. To fix this, add the
missing breaks for each of them.

Caught by Clang's aggressive -Wimplicit-fallthrough, which also warns on
fallthrough to the default case.

- - - - -


1 changed file:

- modules/isa/arm/neon/chroma_yuv.c


Changes:

=====================================
modules/isa/arm/neon/chroma_yuv.c
=====================================
@@ -345,6 +345,7 @@ static int Open (filter_t *filter)
                 default:
                     return VLC_EGENERIC;
             }
+            break;
 
         case VLC_CODEC_UYVY:
             switch (filter->fmt_out.video.i_chroma)
@@ -355,6 +356,7 @@ static int Open (filter_t *filter)
                 default:
                     return VLC_EGENERIC;
             }
+            break;
 
         case VLC_CODEC_YVYU:
             switch (filter->fmt_out.video.i_chroma)
@@ -365,7 +367,7 @@ static int Open (filter_t *filter)
                 default:
                     return VLC_EGENERIC;
             }
-
+            break;
 
         case VLC_CODEC_VYUY:
             switch (filter->fmt_out.video.i_chroma)
@@ -376,6 +378,7 @@ static int Open (filter_t *filter)
                 default:
                     return VLC_EGENERIC;
             }
+            break;
 
         default:
             return VLC_EGENERIC;



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/6815627a5ae43be48baf87a7f529eeb62d1c157c

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/6815627a5ae43be48baf87a7f529eeb62d1c157c
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance