[vlc-commits] [Git][videolan/vlc][master] 3 commits: qml: remove unncessary animation

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
aea180a2 by Prince Gupta at 2022-08-22T20:32:46+00:00
qml: remove unncessary animation

width changes on user action (resize handle), having animation here makes scrubbing slugish

- - - - -
7ee4c634 by Prince Gupta at 2022-08-22T20:32:46+00:00
qml: add scrolling text in artist list

- - - - -
48b5179d by Prince Gupta at 2022-08-22T20:32:46+00:00
qml: add comments on ScrollingText

- - - - -


3 changed files:

- modules/gui/qt/medialibrary/qml/MusicArtistDelegate.qml
- modules/gui/qt/medialibrary/qml/MusicArtistsAlbums.qml
- modules/gui/qt/widgets/qml/ScrollingText.qml


Changes:

=====================================
modules/gui/qt/medialibrary/qml/MusicArtistDelegate.qml
=====================================
@@ -156,15 +156,29 @@ T.Control {
                 }
             }
 
-            Widgets.ListLabel {
-                text: (model.name) ? model.name
-                                   : I18n.qtr("Unknown artist")
+            Widgets.ScrollingText {
+                label: artistName
 
-                color: background.foregroundColor
+                forceScroll: root.isCurrent || root._isHover
+                clip: scrolling
 
                 Layout.fillWidth: true
                 Layout.fillHeight: true
+
+                Widgets.ListLabel {
+                    id: artistName
+
+                    anchors {
+                        verticalCenter: parent.verticalCenter
+                    }
+
+                    text: (model.name) ? model.name
+                                       : I18n.qtr("Unknown artist")
+
+                    color: background.foregroundColor
+                }
             }
+
         }
     }
 }


=====================================
modules/gui/qt/medialibrary/qml/MusicArtistsAlbums.qml
=====================================
@@ -170,13 +170,6 @@ FocusScope {
                 }
             }
 
-            Behavior on width {
-                SmoothedAnimation {
-                    easing.type: Easing.InSine
-                    duration: VLCStyle.duration_veryShort
-                }
-            }
-
             Rectangle {
                 // id: musicArtistLeftBorder
 


=====================================
modules/gui/qt/widgets/qml/ScrollingText.qml
=====================================
@@ -25,6 +25,7 @@ Item {
 
     readonly property alias scrolling: scrollAnimation.running
 
+    // `label`: label to scroll, don't add horizontal anchors on it
     property Text label: undefined
     property bool forceScroll: false
     property alias hoverScroll: hoverArea.enabled



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/78d3fb3833eda250a70b9114555a6e64857b116c...48b5179dce4f663400ecd1ddd14450c20b13fd29

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/78d3fb3833eda250a70b9114555a6e64857b116c...48b5179dce4f663400ecd1ddd14450c20b13fd29
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance