[vlc-commits] [Git][videolan/vlc][master] macosx: Improve library supplementary detail view backgrounds, indicate which...

Jean-Baptiste Kempf (@jbk) gitlab at videolan.org
Sat Aug 27 07:36:29 UTC 2022



Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
697cf079 by Claudio Cambra at 2022-08-27T07:25:06+00:00
macosx: Improve library supplementary detail view backgrounds, indicate which item the detail view is supplementing

Signed-off-by: Claudio Cambra <claudio.cambra at gmail.com>

- - - - -


10 changed files:

- modules/gui/macosx/Makefile.am
- modules/gui/macosx/UI/VLCLibraryCollectionViewAlbumSupplementaryDetailView.xib
- modules/gui/macosx/UI/VLCLibraryCollectionViewAudioGroupSupplementaryDetailView.xib
- modules/gui/macosx/library/VLCLibraryAudioDataSource.m
- modules/gui/macosx/library/VLCLibraryCollectionViewAlbumSupplementaryDetailView.h
- modules/gui/macosx/library/VLCLibraryCollectionViewAlbumSupplementaryDetailView.m
- modules/gui/macosx/library/VLCLibraryCollectionViewAudioGroupSupplementaryDetailView.h
- modules/gui/macosx/library/VLCLibraryCollectionViewAudioGroupSupplementaryDetailView.m
- + modules/gui/macosx/library/VLCLibraryCollectionViewSupplementaryDetailView.h
- + modules/gui/macosx/library/VLCLibraryCollectionViewSupplementaryDetailView.m


Changes:

=====================================
modules/gui/macosx/Makefile.am
=====================================
@@ -68,6 +68,8 @@ libmacosx_plugin_la_SOURCES = \
 	gui/macosx/library/VLCLibraryCollectionViewAlbumSupplementaryDetailView.m \
 	gui/macosx/library/VLCLibraryCollectionViewAudioGroupSupplementaryDetailView.h \
 	gui/macosx/library/VLCLibraryCollectionViewAudioGroupSupplementaryDetailView.m \
+	gui/macosx/library/VLCLibraryCollectionViewSupplementaryDetailView.h \
+	gui/macosx/library/VLCLibraryCollectionViewSupplementaryDetailView.m \
 	gui/macosx/library/VLCLibraryCollectionViewSupplementaryElementView.h \
 	gui/macosx/library/VLCLibraryCollectionViewSupplementaryElementView.m \
 	gui/macosx/library/VLCLibraryController.h \


=====================================
modules/gui/macosx/UI/VLCLibraryCollectionViewAlbumSupplementaryDetailView.xib
=====================================
@@ -2,7 +2,6 @@
 <document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="20037" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES" customObjectInstantitationMethod="direct">
     <dependencies>
         <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="20037"/>
-        <capability name="System colors introduced in macOS 10.14" minToolsVersion="10.0"/>
         <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
     </dependencies>
     <objects>
@@ -13,15 +12,6 @@
             <rect key="frame" x="0.0" y="0.0" width="1071" height="312"/>
             <autoresizingMask key="autoresizingMask" flexibleMinX="YES" widthSizable="YES" flexibleMaxX="YES" flexibleMinY="YES" heightSizable="YES" flexibleMaxY="YES"/>
             <subviews>
-                <box boxType="custom" borderType="none" cornerRadius="4" titlePosition="noTitle" translatesAutoresizingMaskIntoConstraints="NO" id="TDx-ys-0hc">
-                    <rect key="frame" x="0.0" y="0.0" width="1071" height="292"/>
-                    <view key="contentView" id="l4M-qd-E0u">
-                        <rect key="frame" x="0.0" y="0.0" width="1071" height="292"/>
-                        <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
-                    </view>
-                    <color key="borderColor" name="controlColor" catalog="System" colorSpace="catalog"/>
-                    <color key="fillColor" name="separatorColor" catalog="System" colorSpace="catalog"/>
-                </box>
                 <stackView distribution="fill" orientation="horizontal" alignment="top" spacing="20" horizontalStackHuggingPriority="249.99998474121094" verticalStackHuggingPriority="249.99998474121094" detachesHiddenViews="YES" translatesAutoresizingMaskIntoConstraints="NO" id="FWp-yd-2Pm">
                     <rect key="frame" x="10" y="0.0" width="1051" height="282"/>
                     <subviews>
@@ -113,7 +103,7 @@
                                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                                         <subviews>
                                             <tableView verticalHuggingPriority="750" allowsExpansionToolTips="YES" columnAutoresizingStyle="lastColumnOnly" tableStyle="fullWidth" columnReordering="NO" multipleSelection="NO" autosaveColumns="NO" rowHeight="50" viewBased="YES" id="eEJ-WA-0aM" customClass="VLCLibraryTableView">
-                                                <rect key="frame" x="0.0" y="0.0" width="701" height="198"/>
+                                                <rect key="frame" x="0.0" y="0.0" width="701" height="188"/>
                                                 <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                                                 <size key="intercellSpacing" width="3" height="2"/>
                                                 <color key="backgroundColor" red="1" green="1" blue="1" alpha="0.0" colorSpace="custom" customColorSpace="sRGB"/>
@@ -186,13 +176,9 @@
             </subviews>
             <constraints>
                 <constraint firstItem="FWp-yd-2Pm" firstAttribute="leading" secondItem="HAc-or-XD8" secondAttribute="leading" constant="10" id="D62-3E-aDO"/>
-                <constraint firstItem="TDx-ys-0hc" firstAttribute="top" secondItem="HAc-or-XD8" secondAttribute="top" constant="20" id="Wob-l9-MuU"/>
-                <constraint firstItem="TDx-ys-0hc" firstAttribute="leading" secondItem="HAc-or-XD8" secondAttribute="leading" id="adT-vN-en1"/>
-                <constraint firstAttribute="bottom" secondItem="TDx-ys-0hc" secondAttribute="bottom" id="aub-cX-QrF"/>
+                <constraint firstItem="FWp-yd-2Pm" firstAttribute="top" secondItem="HAc-or-XD8" secondAttribute="top" constant="30" id="Mr1-w0-CQK"/>
+                <constraint firstAttribute="bottom" secondItem="FWp-yd-2Pm" secondAttribute="bottom" id="bUH-jE-TQQ"/>
                 <constraint firstAttribute="trailing" secondItem="FWp-yd-2Pm" secondAttribute="trailing" constant="10" id="cPm-6m-umY"/>
-                <constraint firstItem="FWp-yd-2Pm" firstAttribute="top" secondItem="TDx-ys-0hc" secondAttribute="top" constant="10" id="cVs-ac-sSk"/>
-                <constraint firstAttribute="trailing" secondItem="TDx-ys-0hc" secondAttribute="trailing" id="g3s-Ri-jQ5"/>
-                <constraint firstItem="FWp-yd-2Pm" firstAttribute="bottom" secondItem="TDx-ys-0hc" secondAttribute="bottom" id="pZF-BE-cG1"/>
             </constraints>
             <connections>
                 <outlet property="albumArtworkImageView" destination="xZd-Hk-h2M" id="J8l-V9-P06"/>
@@ -207,6 +193,6 @@
     <resources>
         <image name="no-art" width="128" height="128"/>
         <image name="play.fill" catalog="system" width="12" height="13"/>
-        <image name="plus" catalog="system" width="15" height="13"/>
+        <image name="plus" catalog="system" width="14" height="13"/>
     </resources>
 </document>


=====================================
modules/gui/macosx/UI/VLCLibraryCollectionViewAudioGroupSupplementaryDetailView.xib
=====================================
@@ -2,7 +2,6 @@
 <document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="20037" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES" customObjectInstantitationMethod="direct">
     <dependencies>
         <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="20037"/>
-        <capability name="System colors introduced in macOS 10.14" minToolsVersion="10.0"/>
         <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
     </dependencies>
     <objects>
@@ -13,15 +12,6 @@
             <rect key="frame" x="0.0" y="0.0" width="1071" height="322"/>
             <autoresizingMask key="autoresizingMask" flexibleMinX="YES" widthSizable="YES" flexibleMaxX="YES" flexibleMinY="YES" heightSizable="YES" flexibleMaxY="YES"/>
             <subviews>
-                <box boxType="custom" borderType="none" cornerRadius="4" titlePosition="noTitle" translatesAutoresizingMaskIntoConstraints="NO" id="TDx-ys-0hc">
-                    <rect key="frame" x="0.0" y="0.0" width="1071" height="302"/>
-                    <view key="contentView" id="l4M-qd-E0u">
-                        <rect key="frame" x="0.0" y="0.0" width="1071" height="302"/>
-                        <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
-                    </view>
-                    <color key="borderColor" name="controlColor" catalog="System" colorSpace="catalog"/>
-                    <color key="fillColor" name="separatorColor" catalog="System" colorSpace="catalog"/>
-                </box>
                 <stackView distribution="fill" orientation="vertical" alignment="leading" spacing="5" horizontalStackHuggingPriority="249.99998474121094" verticalStackHuggingPriority="249.99998474121094" detachesHiddenViews="YES" translatesAutoresizingMaskIntoConstraints="NO" id="bw7-QB-Ssc">
                     <rect key="frame" x="10" y="10" width="1051" height="282"/>
                     <subviews>
@@ -44,7 +34,7 @@
                                         <rect key="frame" x="0.0" y="0.0" width="701" height="188"/>
                                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                                         <size key="intercellSpacing" width="3" height="2"/>
-                                        <color key="backgroundColor" red="0" green="0" blue="0" alpha="0.0" colorSpace="custom" customColorSpace="sRGB"/>
+                                        <color key="backgroundColor" red="0.0" green="0.0" blue="0.0" alpha="0.0" colorSpace="custom" customColorSpace="sRGB"/>
                                         <color key="gridColor" name="gridColor" catalog="System" colorSpace="catalog"/>
                                         <tableColumns>
                                             <tableColumn width="689" minWidth="10" maxWidth="3.4028234663852886e+38" id="fqq-am-CS8">
@@ -86,14 +76,10 @@
                 </stackView>
             </subviews>
             <constraints>
-                <constraint firstItem="bw7-QB-Ssc" firstAttribute="leading" secondItem="TDx-ys-0hc" secondAttribute="leading" constant="10" id="8h8-eA-iuE"/>
-                <constraint firstItem="TDx-ys-0hc" firstAttribute="trailing" secondItem="bw7-QB-Ssc" secondAttribute="trailing" constant="10" id="HSf-Hj-QAZ"/>
-                <constraint firstItem="TDx-ys-0hc" firstAttribute="top" secondItem="HAc-or-XD8" secondAttribute="top" constant="20" id="Wob-l9-MuU"/>
-                <constraint firstItem="TDx-ys-0hc" firstAttribute="leading" secondItem="HAc-or-XD8" secondAttribute="leading" id="adT-vN-en1"/>
-                <constraint firstAttribute="bottom" secondItem="TDx-ys-0hc" secondAttribute="bottom" id="aub-cX-QrF"/>
-                <constraint firstItem="TDx-ys-0hc" firstAttribute="bottom" secondItem="bw7-QB-Ssc" secondAttribute="bottom" constant="10" id="ezO-kW-CQH"/>
-                <constraint firstAttribute="trailing" secondItem="TDx-ys-0hc" secondAttribute="trailing" id="g3s-Ri-jQ5"/>
-                <constraint firstItem="bw7-QB-Ssc" firstAttribute="top" secondItem="TDx-ys-0hc" secondAttribute="top" constant="10" id="xKr-cT-vGa"/>
+                <constraint firstAttribute="trailing" secondItem="bw7-QB-Ssc" secondAttribute="trailing" constant="10" id="8QK-wS-vnX"/>
+                <constraint firstItem="bw7-QB-Ssc" firstAttribute="leading" secondItem="HAc-or-XD8" secondAttribute="leading" constant="10" id="L0r-A5-7Xq"/>
+                <constraint firstAttribute="bottom" secondItem="bw7-QB-Ssc" secondAttribute="bottom" constant="10" id="eS3-iK-oGV"/>
+                <constraint firstItem="bw7-QB-Ssc" firstAttribute="top" secondItem="HAc-or-XD8" secondAttribute="top" constant="30" id="oWk-8b-f1e"/>
             </constraints>
             <connections>
                 <outlet property="audioGroupAlbumsTableView" destination="eEJ-WA-0aM" id="l8k-M9-a8e"/>


=====================================
modules/gui/macosx/library/VLCLibraryAudioDataSource.m
=====================================
@@ -396,6 +396,7 @@ viewForSupplementaryElementOfKind:(NSCollectionViewSupplementaryElementKind)kind
 
         VLCMediaLibraryAlbum *album = _displayedCollection[indexPath.item];
         albumSupplementaryDetailView.representedAlbum = album;
+        albumSupplementaryDetailView.selectedItemFrame = [collectionView frameForItemAtIndex:indexPath.item];
 
         return albumSupplementaryDetailView;
 
@@ -405,6 +406,7 @@ viewForSupplementaryElementOfKind:(NSCollectionViewSupplementaryElementKind)kind
 
         id<VLCMediaLibraryAudioGroupProtocol> audioGroup = _displayedCollection[indexPath.item];
         audioGroupSupplementaryDetailView.representedAudioGroup = audioGroup;
+        audioGroupSupplementaryDetailView.selectedItemFrame = [collectionView frameForItemAtIndex:indexPath.item];
 
         return audioGroupSupplementaryDetailView;
     }


=====================================
modules/gui/macosx/library/VLCLibraryCollectionViewAlbumSupplementaryDetailView.h
=====================================
@@ -1,5 +1,5 @@
 /*****************************************************************************
- * VLCLibraryCollectionViewSupplementaryDetailView.h: MacOS X interface module
+ * VLCLibraryCollectionViewAlbumSupplementaryDetailView.h: MacOS X interface module
  *****************************************************************************
  * Copyright (C) 2022 VLC authors and VideoLAN
  *
@@ -19,7 +19,9 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
+
 #import <Cocoa/Cocoa.h>
+#import "VLCLibraryCollectionViewSupplementaryDetailView.h"
 
 NS_ASSUME_NONNULL_BEGIN
 
@@ -29,7 +31,7 @@ NS_ASSUME_NONNULL_BEGIN
 extern NSString *const VLCLibraryCollectionViewAlbumSupplementaryDetailViewIdentifier;
 extern NSCollectionViewSupplementaryElementKind const VLCLibraryCollectionViewAlbumSupplementaryDetailViewKind;
 
- at interface VLCLibraryCollectionViewAlbumSupplementaryDetailView : NSView <NSCollectionViewElement>
+ at interface VLCLibraryCollectionViewAlbumSupplementaryDetailView : VLCLibraryCollectionViewSupplementaryDetailView
 
 @property (readwrite, retain, nonatomic) VLCMediaLibraryAlbum *representedAlbum;
 @property (readwrite, weak) IBOutlet NSTextField *albumTitleTextField;
@@ -43,4 +45,4 @@ extern NSCollectionViewSupplementaryElementKind const VLCLibraryCollectionViewAl
 
 @end
 
-NS_ASSUME_NONNULL_END
\ No newline at end of file
+NS_ASSUME_NONNULL_END


=====================================
modules/gui/macosx/library/VLCLibraryCollectionViewAlbumSupplementaryDetailView.m
=====================================
@@ -1,5 +1,5 @@
 /*****************************************************************************
- * VLCLibraryCollectionViewSupplementaryDetailView.m: MacOS X interface module
+ * VLCLibraryCollectionViewAlbumSupplementaryDetailView.m: MacOS X interface module
  *****************************************************************************
  * Copyright (C) 2021 VLC authors and VideoLAN
  *
@@ -121,4 +121,4 @@ NSCollectionViewSupplementaryElementKind const VLCLibraryCollectionViewAlbumSupp
     }];
 }
 
- at end
\ No newline at end of file
+ at end


=====================================
modules/gui/macosx/library/VLCLibraryCollectionViewAudioGroupSupplementaryDetailView.h
=====================================
@@ -21,6 +21,7 @@
  *****************************************************************************/
 
 #import <Cocoa/Cocoa.h>
+#import "VLCLibraryCollectionViewSupplementaryDetailView.h"
 
 NS_ASSUME_NONNULL_BEGIN
 
@@ -30,7 +31,7 @@ NS_ASSUME_NONNULL_BEGIN
 extern NSString *const VLCLibraryCollectionViewAudioGroupSupplementaryDetailViewIdentifier;
 extern NSCollectionViewSupplementaryElementKind const VLCLibraryCollectionViewAudioGroupSupplementaryDetailViewKind;
 
- at interface VLCLibraryCollectionViewAudioGroupSupplementaryDetailView : NSView <NSCollectionViewElement>
+ at interface VLCLibraryCollectionViewAudioGroupSupplementaryDetailView : VLCLibraryCollectionViewSupplementaryDetailView
 
 @property (readwrite, retain, nonatomic) id<VLCMediaLibraryAudioGroupProtocol> representedAudioGroup;
 @property (readwrite, weak) IBOutlet NSTextField *audioGroupNameTextField;
@@ -40,4 +41,4 @@ extern NSCollectionViewSupplementaryElementKind const VLCLibraryCollectionViewAu
 
 @end
 
-NS_ASSUME_NONNULL_END
\ No newline at end of file
+NS_ASSUME_NONNULL_END


=====================================
modules/gui/macosx/library/VLCLibraryCollectionViewAudioGroupSupplementaryDetailView.m
=====================================
@@ -66,4 +66,4 @@ NSCollectionViewSupplementaryElementKind const VLCLibraryCollectionViewAudioGrou
     [_audioGroupAlbumsTableView reloadData];
 }
 
- at end
\ No newline at end of file
+ at end


=====================================
modules/gui/macosx/library/VLCLibraryCollectionViewSupplementaryDetailView.h
=====================================
@@ -0,0 +1,35 @@
+/*****************************************************************************
+ * VLCLibraryCollectionViewSupplementaryDetailView.h: MacOS X interface module
+ *****************************************************************************
+ * Copyright (C) 2022 VLC authors and VideoLAN
+ *
+ * Authors: Claudio Cambra <claudio.cambra at gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
+ *****************************************************************************/
+#import <Cocoa/Cocoa.h>
+
+NS_ASSUME_NONNULL_BEGIN
+
+// This class can be subclassed to create new supplementary detail views for library views.
+// It provides a consistent background and properties. It is not meant to be used directly.
+
+ at interface VLCLibraryCollectionViewSupplementaryDetailView : NSView <NSCollectionViewElement>
+
+ at property (readwrite, assign) NSRect selectedItemFrame;
+
+ at end
+
+NS_ASSUME_NONNULL_END


=====================================
modules/gui/macosx/library/VLCLibraryCollectionViewSupplementaryDetailView.m
=====================================
@@ -0,0 +1,84 @@
+/*****************************************************************************
+ * VLCLibraryCollectionViewSupplementaryDetailView.m: MacOS X interface module
+ *****************************************************************************
+ * Copyright (C) 2022 VLC authors and VideoLAN
+ *
+ * Authors: Claudio Cambra <claudio.cambra at gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
+ *****************************************************************************/
+
+#import "VLCLibraryCollectionViewSupplementaryDetailView.h"
+
+static const CGFloat kArrowHeight = 20.;
+static const CGFloat kArrowWidth = 50.;
+static const CGFloat kArrowTipRadius = 2.5;
+static const CGFloat kBackgroundCornerRadius = 10.;
+
+ at interface VLCLibraryCollectionViewSupplementaryDetailView ()
+{
+    NSSize _arrowSize;
+}
+ at end
+
+ at implementation VLCLibraryCollectionViewSupplementaryDetailView
+
+- (void)drawRect:(NSRect)dirtyRect {
+    if(NSEqualSizes(_arrowSize, NSZeroSize)) {
+        _arrowSize = NSMakeSize(kArrowWidth, kArrowHeight);
+    }
+
+    NSPoint itemCenterPoint = NSMakePoint(NSMinX(_selectedItemFrame) + NSWidth(_selectedItemFrame) / 2,
+                                          NSMinY(_selectedItemFrame) + NSHeight(_selectedItemFrame) / 2);
+    NSRect backgroundRect = NSMakeRect(NSMinX(self.bounds),
+                                       NSMinY(self.bounds), NSWidth(self.bounds) + 2,
+                                       NSHeight(self.bounds) - _arrowSize.height);
+    CGFloat backgroundTop = NSMaxY(backgroundRect);
+    CGFloat backgroundLeft = NSMinX(backgroundRect);
+
+    NSPoint arrowLeftPoint = NSMakePoint(itemCenterPoint.x - _arrowSize.width / 2, backgroundTop);
+    NSPoint arrowTopPoint = NSMakePoint(itemCenterPoint.x, backgroundTop - 1);
+    NSPoint arrowRightPoint = NSMakePoint(itemCenterPoint.x + _arrowSize.width / 2, backgroundTop);
+
+    NSPoint topLeftCorner = NSMakePoint(backgroundLeft, backgroundTop);
+    NSPoint topLeftCornerAfterCurve = NSMakePoint(backgroundLeft + kBackgroundCornerRadius, backgroundTop);
+
+    NSBezierPath *backgroundPath = [NSBezierPath bezierPathWithRoundedRect:backgroundRect xRadius:kBackgroundCornerRadius yRadius:kBackgroundCornerRadius];
+    backgroundPath.flatness = 1.0;
+    backgroundPath.lineJoinStyle = NSLineJoinStyleRound;
+    backgroundPath.lineWidth = 0.5;
+
+    [backgroundPath moveToPoint:topLeftCornerAfterCurve];
+    [backgroundPath lineToPoint:arrowLeftPoint];
+    [backgroundPath curveToPoint:arrowTopPoint
+                   controlPoint1:NSMakePoint(itemCenterPoint.x - _arrowSize.width / 6, backgroundTop)
+                   controlPoint2:NSMakePoint(itemCenterPoint.x - kArrowTipRadius, backgroundTop + _arrowSize.height)];
+    [backgroundPath curveToPoint:arrowRightPoint
+                   controlPoint1:NSMakePoint(itemCenterPoint.x + kArrowTipRadius, backgroundTop + _arrowSize.height)
+                   controlPoint2:NSMakePoint(itemCenterPoint.x + _arrowSize.width / 6, backgroundTop)];
+
+    [backgroundPath closePath];
+
+    //[[NSColor.gridColor colorWithAlphaComponent:self.container.alphaValue] setFill];
+    [NSColor.gridColor setFill];
+    [backgroundPath fill];
+
+    //[[NSColor.gridColor colorWithAlphaComponent:self.container.alphaValue] setStroke];
+    [NSColor.gridColor setStroke];
+    [backgroundPath stroke];
+}
+
+ at end
+



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/697cf07910f33399faa8ec19be37e4e6127b639f

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/697cf07910f33399faa8ec19be37e4e6127b639f
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list