[vlc-commits] [Git][videolan/vlc][master] qt: don't use RGB format in FadingEdgeListView

François Cartegnie (@fcartegnie) gitlab at videolan.org
Tue Dec 20 09:06:11 UTC 2022



François Cartegnie pushed to branch master at VideoLAN / VLC


Commits:
b9d4730a by Fatih Uzunoglu at 2022-12-19T21:03:44+03:00
qt: don't use RGB format in FadingEdgeListView

Support for this seems to be lacking with Direct3D,
and ANGLE seems to not take this into consideration.

Starting from Qt 6, it also seems to be not supported
altogether.

- - - - -


1 changed file:

- modules/gui/qt/widgets/qml/FadingEdgeListView.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/FadingEdgeListView.qml
=====================================
@@ -182,14 +182,6 @@ ListView {
 
         smooth: false
 
-        // If background rectangle is fully opaque,
-        // the texture does not need an alpha
-        // channel: (optimization)
-        format: (contentItemCoverRect.visible
-                 && Helpers.compareFloat(1.0, contentItemCoverRect.color.a)
-                 && (displayMarginBeginning <= 0 && displayMarginEnd <= 0)) ? ShaderEffectSource.RGB
-                                                                            : ShaderEffectSource.RGBA
-
         layer.enabled: true
         layer.effect: ShaderEffect {
             // It makes sense to use the effect for only in the fading part.



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/b9d4730aa2c7c1938abca7be8d2f429973b49fe7

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/b9d4730aa2c7c1938abca7be8d2f429973b49fe7
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list