[vlc-commits] [Git][videolan/vlc][master] qt/DirectCompositor: always insert external visual below all siblings

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
35e9aa9d by Prince Gupta at 2022-02-14T09:38:45+00:00
qt/DirectCompositor: always insert external visual below all siblings

it seems the code assumed that null m_videoVisual means that video
visual is not in the visual tree but that assumption is wrong, this
caused the addition of acrylic visual to fail just after the video is
played and stopped. In that case the videoVisual will not be null but
also will not be in visual tree

Always insert acrylic visual below all siblings.
probably fixes #26279

- - - - -


1 changed file:

- modules/gui/qt/maininterface/compositor_dcomp.cpp


Changes:

=====================================
modules/gui/qt/maininterface/compositor_dcomp.cpp
=====================================
@@ -371,7 +371,7 @@ void CompositorDirectComposition::addVisual(Microsoft::WRL::ComPtr<IDComposition
 {
     vlc_assert(m_rootVisual);
 
-    HRESULT hr = m_rootVisual->AddVisual(visual.Get(), FALSE, m_videoVisual ? m_videoVisual.Get() : m_uiVisual.Get());
+    HRESULT hr = m_rootVisual->AddVisual(visual.Get(), TRUE, NULL);
     if (FAILED(hr))
         msg_Err(m_intf, "failed to add visual, code: 0x%lX", hr);
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/35e9aa9dce9df1c5aa974e21a3a31bbdca7822cd

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/35e9aa9dce9df1c5aa974e21a3a31bbdca7822cd
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance