[vlc-commits] [Git][videolan/vlc][master] mkv: fix statement has no effect warning

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
cf8225b3 by Lyndon Brown at 2022-02-21T07:10:01+00:00
mkv: fix statement has no effect warning

Loop revised to c11 style rather than just dropping the unnecessary `t;`
upon request by Alexandre in review.

```
../../modules/demux/mkv/matroska_segment_parse.cpp: In member function 'void mkv::matroska_segment_c::ParseTracks(libmatroska::KaxTracks*)':
WARNING : ../../modules/demux/mkv/matroska_segment_parse.cpp:1102: 10:  statement has no effect [-Wunused-value]
 1102 |     for (t; t != matroska_segment_c::tracks.end(); ++t)
      |          ^
```

- - - - -


1 changed file:

- modules/demux/mkv/matroska_segment_parse.cpp


Changes:

=====================================
modules/demux/mkv/matroska_segment_parse.cpp
=====================================
@@ -1098,10 +1098,9 @@ void matroska_segment_c::ParseTracks( KaxTracks *tracks )
 
     TrackHandlers::Dispatcher().iterate( tracks->begin(), tracks->end(), &payload );
 
-    auto t = matroska_segment_c::tracks.begin();
-    for (t; t != matroska_segment_c::tracks.end(); ++t)
+    for (auto &track : matroska_segment_c::tracks)
     {
-        pcr_shift = std::max(pcr_shift, t->second->i_codec_delay);
+        pcr_shift = std::max(pcr_shift, track.second->i_codec_delay);
     }
 }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/cf8225b3f3ceaeadb37fdf99c0ffb6c4c5010991

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/cf8225b3f3ceaeadb37fdf99c0ffb6c4c5010991
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance