[vlc-commits] [Git][videolan/vlc][master] 4 commits: qt: use strongly-typed connects

[Hugo Beauzée-Luyssen (@chouquette)]

Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC


Commits:
eb0b785f by Lyndon Brown at 2022-02-25T06:47:40+00:00
qt: use strongly-typed connects

This replaces almost all use of `SIGNAL()` and `SLOT()` with Qt5-style
strongly-typed connections. The `CONNECT()`, and `DCONNECT()` helpers
built around them have been removed.

Cases involving the `BUTTON_*` macros will be tackled in a separate
commit to improve clarity.

A few cases remain using `SIGNAL()` and `SLOT()` for now due to
complications that should be dealt with separately.

- - - - -
19d51ba2 by Lyndon Brown at 2022-02-25T06:47:40+00:00
qt: fix deprecation warning

```
../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp: In constructor 'SPrefsPanel::SPrefsPanel(qt_intf_t*, QWidget*, int)':
WARNING : ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp:811: 52:  'void QButtonGroup::buttonClicked(int)' is deprecated: Use QButtonGroup::idClicked(int) instead [-Wdeprecated-declarations]
  811 |             connect( radioGroup, QOverload<int>::of(&QButtonGroup::buttonClicked),
      |                                  ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QButtonGroup:1,
                 from ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp:44:
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qbuttongroup.h:90:10: note: declared here
   90 |     void buttonClicked(int);
      |          ^~~~~~~~~~~~~
```

- - - - -
30618b6a by Lyndon Brown at 2022-02-25T06:47:40+00:00
qt: fix signal-mapper deprecation warnings

I included adaptation here of a few existing cases using a different
solution to the helper defines suggested in review.

Example warning:
```
../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp: In constructor 'SPrefsCatList::SPrefsCatList(qt_intf_t*, QWidget*)':
WARNING : ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp:254: 40:  'void QSignalMapper::mapped(int)' is deprecated: Use QSignalMapper::mappedInt(int) instead [-Wdeprecated-declarations]
  254 |     connect( mapper, QOverload<int>::of(&QSignalMapper::mapped), this, &SPrefsCatList::switchPanel );
      |                      ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/QSignalMapper:1,
                 from ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp:45:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qsignalmapper.h:71:10: note: declared here
   71 |     void mapped(int);
      |          ^~~~~~
```

- - - - -
77b75273 by Lyndon Brown at 2022-02-25T06:47:40+00:00
qt: use strongly-typed connect via button-act/button-set macros

- - - - -


30 changed files:

- modules/gui/qt/dialogs/epg/EPGWidget.cpp
- modules/gui/qt/dialogs/epg/epg.cpp
- modules/gui/qt/dialogs/errors/errors.cpp
- modules/gui/qt/dialogs/extended/extended.cpp
- modules/gui/qt/dialogs/extended/extended_panels.cpp
- modules/gui/qt/dialogs/extensions/extensions.cpp
- modules/gui/qt/dialogs/extensions/extensions_manager.cpp
- modules/gui/qt/dialogs/fingerprint/fingerprintdialog.cpp
- modules/gui/qt/dialogs/gototime/gototime.cpp
- modules/gui/qt/dialogs/help/help.cpp
- modules/gui/qt/dialogs/mediainfo/info_panels.cpp
- modules/gui/qt/dialogs/mediainfo/mediainfo.cpp
- modules/gui/qt/dialogs/messages/messages.cpp
- modules/gui/qt/dialogs/open/open.cpp
- modules/gui/qt/dialogs/open/open_panels.cpp
- modules/gui/qt/dialogs/open/openurl.cpp
- modules/gui/qt/dialogs/plugins/plugins.cpp
- modules/gui/qt/dialogs/podcast/podcast_configuration.cpp
- modules/gui/qt/dialogs/preferences/complete_preferences.cpp
- modules/gui/qt/dialogs/preferences/preferences.cpp
- modules/gui/qt/dialogs/preferences/preferences_widgets.cpp
- modules/gui/qt/dialogs/preferences/simple_preferences.cpp
- modules/gui/qt/dialogs/sout/convert.cpp
- modules/gui/qt/dialogs/sout/profile_selector.cpp
- modules/gui/qt/dialogs/sout/sout.cpp
- modules/gui/qt/dialogs/sout/sout_widgets.cpp
- modules/gui/qt/dialogs/vlm/vlm.cpp
- modules/gui/qt/menus/custom_menus.cpp
- modules/gui/qt/menus/qml_menu_wrapper.cpp
- modules/gui/qt/player/player_controller.cpp


The diff was not included because it is too large.


View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/e0c417db63af2ee511d96ae1a411716dda985169...77b7527379623c163000f2c2a85001d63b3e8467

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/e0c417db63af2ee511d96ae1a411716dda985169...77b7527379623c163000f2c2a85001d63b3e8467
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance