[vlc-commits] [Git][videolan/vlc][master] qml/AnimatedBackground: fix border animation

[Hugo Beauzée-Luyssen (@chouquette)]

Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC


Commits:
331194a8 by Prince Gupta at 2022-02-25T13:05:26+00:00
qml/AnimatedBackground: fix border animation

setting border.width on border.color's Animation.Running signal seems to cause an
invalid state when a previous animation is in progress and border.color
is reset

- - - - -


1 changed file:

- modules/gui/qt/widgets/qml/AnimatedBackground.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/AnimatedBackground.qml
=====================================
@@ -59,6 +59,8 @@ Rectangle {
                   ? root.activeBorderColor
                   : VLCStyle.colors.setColorAlpha(root.activeBorderColor, 0)
 
+    border.width: root.active ? VLCStyle.focus_border : 0
+
     //---------------------------------------------------------------------------------------------
     // Animations
     //---------------------------------------------------------------------------------------------
@@ -68,13 +70,6 @@ Rectangle {
             id: borderAnimation
 
             duration: root.animationDuration
-            onRunningChanged: {
-                if (running && root.active) {
-                    border.width = Qt.binding(function() { return VLCStyle.focus_border })
-                } else if (!running && !root.active) {
-                    border.width = 0
-                }
-            }
         }
     }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/331194a85c57bd7284d641c3dd3b3bad3d6465c9

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/331194a85c57bd7284d641c3dd3b3bad3d6465c9
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance