[vlc-commits] [Git][videolan/vlc][master] vout: fix palette double free

Rémi Denis-Courmont (@Courmisch) gitlab at videolan.org
Tue Jan 11 07:49:37 UTC 2022



Rémi Denis-Courmont pushed to branch master at VideoLAN / VLC


Commits:
3dc5ed78 by Rémi Denis-Courmont at 2022-01-11T07:35:59+00:00
vout: fix palette double free

As of the last rework, ownership of the original format has already been
passed to the video output by the point of enabling the window. It is
kept until the next format change, or the destruction of the video
output. So it shall not be freed if enabling the window fails.

- - - - -


1 changed file:

- src/video_output/video_output.c


Changes:

=====================================
src/video_output/video_output.c
=====================================
@@ -2082,7 +2082,6 @@ int vout_Request(const vout_configuration_t *cfg, vlc_video_context *vctx, input
     {
         /* the window was not enabled, nor the display started */
         msg_Err(cfg->vout, "failed to enable window");
-        video_format_Clean(&original);
         vlc_mutex_unlock(&sys->window_lock);
         assert(sys->display == NULL);
         return -1;



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/3dc5ed78966643bbba8ff4c3fb2785330f174263

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/3dc5ed78966643bbba8ff4c3fb2785330f174263
You're receiving this email because of your account on code.videolan.org.




More information about the vlc-commits mailing list