[vlc-commits] [Git][videolan/vlc][3.0.x] qt: unmap indirection X11 window before reparenting it back to root

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch 3.0.x at VideoLAN / VLC


Commits:
97244141 by Sebastian Keller at 2022-07-23T09:12:39+00:00
qt: unmap indirection X11 window before reparenting it back to root

Reparenting a mapped window to root causes it to become a toplevel
window and can cause window managers to reparent the window themselves
to show their decorations.

This could happen in two situations:

1. Theoretically it could happen briefly between WindowReleased and
   WindowClose.
2. It could trigger a race between VLC and the WM if there is a quick
   sequence of WindowOpen -> WindowReleased -> WindowClose -> WindowOpen
   such as when using single instance mode. If the X-server in this
   situation happens to re-use the XID of the X11 indirection window
   from the first WindowOpen for the second WindowOpen, this could
   result in the following race:
   - VLC creates a new X11 indirection window, reparents and maps it
   - VLC reparents it to root
   - VLC closes the connection, freeing the XID
   - VLC opens a new connection
   - VLC creates a new indirection window with the same XID as before
     and reparents and maps it
   - The X-server sends a MapRequest for the *first* X11 indirection
     window caused by the reparent to root to the WM
   - The WM sees a new toplevel window and reparents it. Because the XID
     used by that reparent request is the same as of the newly created
     indirection window, the new window ends up getting reparented.
   This then would result in the indirection window remaining as
   toplevel window. The exact order might change slightly between the
   different processes, but as long as the reparent request by the WM is
   the last one, the issue will trigger.

Closes #25692

- - - - -


1 changed file:

- modules/gui/qt/qt.cpp


Changes:

=====================================
modules/gui/qt/qt.cpp
=====================================
@@ -838,6 +838,7 @@ void WindowOrphaned(vout_window_t *wnd)
          * window, WindowOpen() will skip reparenting. Then this call will be
          * a no-op.
          */
+        XUnmapWindow (sys->dpy, wnd->handle.xid);
         XReparentWindow(sys->dpy, wnd->handle.xid,
                         RootWindow(sys->dpy, DefaultScreen(sys->dpy)), 0, 0);
         XSync(sys->dpy, True);



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/97244141017e4f1cf8ee5f7943d571f4ee951c28

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/97244141017e4f1cf8ee5f7943d571f4ee951c28
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance