[vlc-commits] [Git][videolan/vlc][3.0.x] contrib: upnp: disable webserver and device handling

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch 3.0.x at VideoLAN / VLC


Commits:
e0a99d63 by Alaric Senat at 2022-06-13T14:01:52+00:00
contrib: upnp: disable webserver and device handling

VLC 3.0 uses libupnp exclusively as a client. LibUpnp internals are
quite opaque and it has been observed that a webserver thread is still
running on idle with open sockets even if the library is used as a
client only.

The recent bump to 1.14 introduces regressions in libupnp's webserver
socket initialization [1] on windows. Since the bug is still not
corrected upstream and we don't have any use of the webserver for 3.0
anyway, let's just disable it.

[1] https://github.com/pupnp/pupnp/issues/195

Fixes videolan/vlc#27001

- - - - -


1 changed file:

- contrib/src/upnp/rules.mak


Changes:

=====================================
contrib/src/upnp/rules.mak
=====================================
@@ -16,7 +16,7 @@ $(TARBALLS)/pupnp-release-$(UPNP_VERSION).tar.gz:
 
 UPNP_CFLAGS := $(CFLAGS) -DUPNP_STATIC_LIB
 UPNP_CXXFLAGS := $(CXXFLAGS) -DUPNP_STATIC_LIB
-UPNP_CONF := --disable-samples
+UPNP_CONF := --disable-samples --disable-device --disable-webserver
 
 ifdef HAVE_WIN32
 DEPS_upnp += pthreads $(DEPS_pthreads)



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/e0a99d6364f4a0e57cdbd81a71c9fa04f052a260

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/e0a99d6364f4a0e57cdbd81a71c9fa04f052a260
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance