[vlc-commits] [Git][videolan/vlc][master] 2 commits: messages: remove always NULL parameter

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
702b1eeb by Steve Lhomme at 2022-06-23T17:08:30+00:00
messages: remove always NULL parameter

8b0dd8cfdff0d9697fb44e7849764c9274965adb removed the use of the verbosity level
that was found in libvlc_priv_t. It is no longer available with the vlc_logger.

All logs are generated on Windows, no matter the verbosity level.

- - - - -
be790d9d by Steve Lhomme at 2022-06-23T17:08:30+00:00
vlc_messages: fix documentation referencing vlc_msg_SetCallback()

It's actually vlc_LogSet()

- - - - -


2 changed files:

- include/vlc_messages.h
- src/misc/messages.c


Changes:

=====================================
include/vlc_messages.h
=====================================
@@ -142,7 +142,7 @@ VLC_API void vlc_vaLog(struct vlc_logger *const *logger, int prio,
 
 /**
  * Message logging callback signature.
- * \param data data pointer as provided to vlc_msg_SetCallback().
+ * \param data data pointer as provided to vlc_LogSet().
  * \param type message type (VLC_MSG_* values from enum vlc_log_type)
  * \param item meta information
  * \param fmt format string


=====================================
src/misc/messages.c
=====================================
@@ -79,7 +79,7 @@ static void vlc_LogCallback(vlc_logger_t *logger, int type,
 }
 
 #ifdef _WIN32
-static void Win32DebugOutputMsg (void *, int , const vlc_log_t *,
+static void Win32DebugOutputMsg (int , const vlc_log_t *,
                                  const char *, va_list);
 #endif
 
@@ -120,7 +120,7 @@ void vlc_vaLog(struct vlc_logger *const *loggerp, int type,
     va_list ap;
 
     va_copy (ap, args);
-    Win32DebugOutputMsg (NULL, type, &msg, format, ap);
+    Win32DebugOutputMsg (type, &msg, format, ap);
     va_end (ap);
 #endif
 
@@ -144,15 +144,11 @@ void vlc_Log(struct vlc_logger *const *logger, int type,
 #ifdef _WIN32
 static const char msg_type[4][9] = { "", " error", " warning", " debug" };
 
-static void Win32DebugOutputMsg (void* d, int type, const vlc_log_t *p_item,
+static void Win32DebugOutputMsg (int type, const vlc_log_t *p_item,
                                  const char *format, va_list dol)
 {
     VLC_UNUSED(p_item);
 
-    const signed char *pverbose = d;
-    if (pverbose && (*pverbose < 0 || *pverbose < (type - VLC_MSG_ERR)))
-        return;
-
     va_list dol2;
     va_copy (dol2, dol);
     int msg_len = vsnprintf(NULL, 0, format, dol2);



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/2e08074d36eaf633db022acf4727012cce4c1b31...be790d9dc82df6e7c24422ce3b119336a8070c13

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/2e08074d36eaf633db022acf4727012cce4c1b31...be790d9dc82df6e7c24422ce3b119336a8070c13
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance