[vlc-commits] [Git][videolan/vlc][master] 3 commits: qml: expose *margin properties in KeyNavigableTableView

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
afcbf621 by Prince Gupta at 2022-06-24T09:14:47+00:00
qml: expose *margin properties in KeyNavigableTableView

- - - - -
7f8dfda3 by Prince Gupta at 2022-06-24T09:14:47+00:00
qml: fix keyboard focus in video view

add top margin through underlying view instead of header
the view considers top margins when scrolling the view
for keyboard navigation, this ensures sufficient space for delegate

fixes #27065

- - - - -
0391b33a by Prince Gupta at 2022-06-24T09:14:47+00:00
qml: remove extra top padding from video list main view

- - - - -


4 changed files:

- modules/gui/qt/medialibrary/qml/VideoAll.qml
- modules/gui/qt/medialibrary/qml/VideoAllSubDisplay.qml
- modules/gui/qt/medialibrary/qml/VideoDisplayRecentVideos.qml
- modules/gui/qt/widgets/qml/KeyNavigableTableView.qml


Changes:

=====================================
modules/gui/qt/medialibrary/qml/VideoAll.qml
=====================================
@@ -202,6 +202,8 @@ FocusScope {
             cellWidth : VLCStyle.gridItem_video_width
             cellHeight: VLCStyle.gridItem_video_height
 
+            topMargin: VLCStyle.margin_normal
+
             model: root.model
 
             selectionDelegateModel: modelSelect
@@ -331,7 +333,7 @@ FocusScope {
 
             header: root.header
 
-            headerTopPadding: VLCStyle.margin_normal
+            topMargin: VLCStyle.margin_normal
 
             headerPositioning: ListView.InlineHeader
 


=====================================
modules/gui/qt/medialibrary/qml/VideoAllSubDisplay.qml
=====================================
@@ -227,6 +227,9 @@ VideoAll {
         // NOTE: We want grid items to be visible on the sides.
         leftPadding: root.contentMargin
 
+        // spacing between header and content
+        bottomPadding: VLCStyle.margin_normal
+
         Navigation.parentItem: root
 
         Navigation.downAction: function() {


=====================================
modules/gui/qt/medialibrary/qml/VideoDisplayRecentVideos.qml
=====================================
@@ -32,6 +32,8 @@ FocusScope {
 
     property alias leftPadding: recentVideosColumn.leftPadding
     property alias rightPadding: recentVideosColumn.rightPadding
+    property alias topPadding: recentVideosColumn.topPadding
+    property alias bottomPadding: recentVideosColumn.bottomPadding
 
     property alias subtitleText : subtitleLabel.text
 
@@ -65,10 +67,6 @@ FocusScope {
 
         spacing: VLCStyle.margin_xsmall
 
-        topPadding: VLCStyle.margin_normal
-
-        bottomPadding: VLCStyle.margin_normal
-
         Widgets.SubtitleLabel {
             text: I18n.qtr("Continue Watching")
 


=====================================
modules/gui/qt/widgets/qml/KeyNavigableTableView.qml
=====================================
@@ -89,6 +89,11 @@ FocusScope {
 
     // Aliases
 
+    property alias topMargin: view.topMargin
+    property alias bottomMargin: view.bottomMargin
+    property alias leftMargin: view.leftMargin
+    property alias rightMargin: view.rightMargin
+
     property alias spacing: view.spacing
 
     property alias model: view.model



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/c3c2d535cc05c8d8b32519a7b7f4e4a02b502663...0391b33a9029c47e5c8ba27bd7493fac1ab8a232

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/c3c2d535cc05c8d8b32519a7b7f4e4a02b502663...0391b33a9029c47e5c8ba27bd7493fac1ab8a232
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance