[vlc-commits] [Git][videolan/vlc][master] 2 commits: dvbsub: update note

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
b39ffc48 by Lyndon Brown at 2022-06-24T16:42:54+00:00
dvbsub: update note

'i_segment_length' should clearly be included here.

- - - - -
43c69bf2 by Lyndon Brown at 2022-06-24T16:42:54+00:00
dvbsub: clarify a note

this note unhelpfully did not specify which version of the standard, nor
the section title, causing unnecessary difficulty identifying the
applicable text.

i identified the applicable section as being titled 'Object data segment'
which, in versions 1.5.1 and 1.6.1 is now located at section 7.2.5 rather
than 7.2.4 (from the official standards linked at [1]).

i have thus:
 - added a version number, along with section title.
 - updated the section number to go along witht hat version number.
 - switched to use the term 'section' rather than paragraph.

i haven't updated the rest of the references yet since for whatever reason
i neglected to do so when i originally made this patch and i'm too out of
touch with it now.

[1]: https://dvb.org/specifications/

- - - - -


1 changed file:

- modules/codec/dvbsub.c


Changes:

=====================================
modules/codec/dvbsub.c
=====================================
@@ -1068,8 +1068,8 @@ static void decode_object( decoder_t *p_dec, bs_t *s, uint16_t i_segment_length
     dvbsub_region_t *p_region;
     int i_coding_method, i_id, i;
 
-    /* ETSI 300-743 paragraph 7.2.4
-     * sync_byte, segment_type and page_id have already been processed.
+    /* ETSI 300-743 v1.5.1 section 7.2.5 'Object data segment'
+     * sync_byte, segment_type, page_id and i_segment_length have already been processed.
      */
     i_id             = bs_read( s, 16 );
     bs_skip( s, 4 ); /* version */



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/82886b4597230aa4e6911321ec4a2c2562e5288b...43c69bf27b15b40818102886f4987d68b6cd2b27

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/82886b4597230aa4e6911321ec4a2c2562e5288b...43c69bf27b15b40818102886f4987d68b6cd2b27
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance