[vlc-commits] [Git][videolan/vlc][master] keystore: use the system keystore from the first try

[Rémi Denis-Courmont (@Courmisch)]

Rémi Denis-Courmont pushed to branch master at VideoLAN / VLC


Commits:
8ba757d4 by Thomas Guillem at 2022-03-02T15:45:18+00:00
keystore: use the system keystore from the first try

Currently, all access modules are first requesting credentials without
triggering a dialog. This caused the system keystore to never be fetched
on the first try. Therefore some access modules could fallback to a
guest/anonymous account when a valid credential was saved on the system
keystore.

Now the system keystore will be fetched from the first try. Access
modules will still fallback to a guest/anonymous account if the system
keystore doesn't have any credentials (before prompting credentials via
a dialog).

- - - - -


1 changed file:

- src/misc/keystore.c


Changes:

=====================================
src/misc/keystore.c
=====================================
@@ -446,9 +446,6 @@ vlc_credential_get(vlc_credential *p_credential, vlc_object_t *p_parent,
         }
 
         case GET_FROM_KEYSTORE:
-            if (!psz_dialog_title || !psz_dialog_fmt)
-                return false;
-
             if (p_credential->p_keystore == NULL)
                 p_credential->p_keystore = vlc_keystore_create(p_parent);
             if (p_credential->p_keystore != NULL)



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/8ba757d42d2e45f5feba14d93554a3d9ac29e257

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/8ba757d42d2e45f5feba14d93554a3d9ac29e257
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance