[vlc-commits] [Git][videolan/vlc][master] mp4: fix null deref

[Rémi Denis-Courmont (@Courmisch)]

Rémi Denis-Courmont pushed to branch master at VideoLAN / VLC


Commits:
8a88f100 by Lyndon Brown at 2022-03-12T07:24:39+00:00
mp4: fix null deref

This used one too many derefs, and then due to the earlier write of null
near the beginning of the function (making a null write here redundant)
there was thus a null-deref.

Regression from 0e9db4f7e603e88488f414b7ef44ba8c323f4df0.

- - - - -


1 changed file:

- modules/demux/mp4/attachments.c


Changes:

=====================================
modules/demux/mp4/attachments.c
=====================================
@@ -371,7 +371,6 @@ size_t MP4_GetAttachments( const MP4_Box_t *p_root, input_attachment_t ***ppp_at
     if ( i_count == 0 )
     {
         free( pp_attach );
-        **ppp_attach = NULL;
         return 0;
     }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/8a88f1005cef73a066f8aafce1a66b95a2c7257b

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/8a88f1005cef73a066f8aafce1a66b95a2c7257b
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance