[vlc-commits] [Git][videolan/vlc][master] 2 commits: qml: further limit miniplayer background effect source

Rémi Denis-Courmont (@Courmisch) gitlab at videolan.org
Sat Mar 26 09:15:42 UTC 2022



Rémi Denis-Courmont pushed to branch master at VideoLAN / VLC


Commits:
8cccbacd by Fatih Uzunoglu at 2022-03-26T08:49:35+00:00
qml: further limit miniplayer background effect source

- - - - -
1f22b3f3 by Fatih Uzunoglu at 2022-03-26T08:49:35+00:00
qml: use Item as root type

- - - - -


3 changed files:

- modules/gui/qt/maininterface/qml/MainDisplay.qml
- modules/gui/qt/maininterface/qml/MainInterface.qml
- modules/gui/qt/player/qml/MiniPlayer.qml


Changes:

=====================================
modules/gui/qt/maininterface/qml/MainDisplay.qml
=====================================
@@ -463,7 +463,12 @@ FocusScope {
                         stackView.forceActiveFocus()
                 }
 
-                effectSource: mainColumn
+                effectSource: stackView
+                effectSourceRect: effectSource.mapFromItem(parent,
+                                                           x,
+                                                           y,
+                                                           width,
+                                                           height)
             }
 
             Connections {


=====================================
modules/gui/qt/maininterface/qml/MainInterface.qml
=====================================
@@ -30,9 +30,9 @@ import "qrc:///style/"
 import "qrc:///dialogs/" as DG
 import "qrc:///playlist/" as PL
 
-Rectangle {
+Item {
     id: root
-    color: "transparent"
+
     property bool _interfaceReady: false
     property bool _playlistReady: false
 


=====================================
modules/gui/qt/player/qml/MiniPlayer.qml
=====================================
@@ -34,6 +34,7 @@ FocusScope {
     visible: false
 
     property alias effectSource: effect.source
+    property alias effectSourceRect: effect.sourceRect
 
     state: (Player.playingState === Player.PLAYING_STATE_STOPPED) ? ""
                                                                   : "expanded"
@@ -70,11 +71,6 @@ FocusScope {
         id: effect
         anchors.fill: parent
 
-        sourceRect: Qt.rect(root.x,
-                            root.y,
-                            root.width,
-                            root.height)
-
         tint: VLCStyle.colors.lowerBanner
     }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/ee685295142fd0395c00bb2c056900975c7f56dd...1f22b3f3aebde531bade51681c655ff4051b5617

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/ee685295142fd0395c00bb2c056900975c7f56dd...1f22b3f3aebde531bade51681c655ff4051b5617
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list