[vlc-commits] [Git][videolan/vlc][master] 2 commits: musicbrainz: fix inverted logic

[Hugo Beauzée-Luyssen (@chouquette)]

Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC


Commits:
4d81c81c by Lyndon Brown at 2022-03-30T09:38:26+00:00
musicbrainz: fix inverted logic

and fix leak with the corrected logic.

- - - - -
11c4e593 by Lyndon Brown at 2022-03-30T09:38:26+00:00
musicbrainz: fix wrong url

inconsistent with that used in `coverartarchive_make_releasegroup_arturl()`.

i believe that with-dash is likely the correct form, since firstly, that
function is actually used unlike this one, and this function was also
fundamentally broken before the previous commit. also secondly, the info
at [1] seems to indicate that with-dash is correct.

[1]: https://github.com/Borewit/musicbrainz-api

- - - - -


1 changed file:

- modules/misc/webservices/musicbrainz.c


Changes:

=====================================
modules/misc/webservices/musicbrainz.c
=====================================
@@ -331,8 +331,9 @@ coverartarchive_t * coverartarchive_lookup_releasegroup(musicbrainz_config_t *cf
         return NULL;
 
     char *psz_url;
-    if(0 < asprintf(&psz_url, "https://%s/releasegroup/%s", cfg->psz_coverart_server, psz_id ))
+    if(asprintf(&psz_url, "https://%s/release-group/%s", cfg->psz_coverart_server, psz_id) < 0)
     {
+        free(c);
         return NULL;
     }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/aeedea5abf9f4031964bf95dee5034bc2219c501...11c4e593ceb0c87829d8a03c788c09fee38b78c1

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/aeedea5abf9f4031964bf95dee5034bc2219c501...11c4e593ceb0c87829d8a03c788c09fee38b78c1
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance