[vlc-commits] [Git][videolan/vlc][master] qt: add missing virtual destructor

[Hugo Beauzée-Luyssen (@chouquette)]

Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC


Commits:
7e47fa52 by Pierre Lamot at 2022-03-31T08:05:41+00:00
qt: add missing virtual destructor

- - - - -


6 changed files:

- modules/gui/qt/dialogs/vlm/vlm.hpp
- modules/gui/qt/maininterface/compositor.hpp
- modules/gui/qt/medialibrary/medialib.hpp
- modules/gui/qt/medialibrary/mlfoldersmodel.hpp
- modules/gui/qt/util/asynctask.hpp
- modules/gui/qt/util/selectable_list_model.hpp


Changes:

=====================================
modules/gui/qt/dialogs/vlm/vlm.hpp
=====================================
@@ -149,6 +149,7 @@ public:
     VLMAWidget( VLMWrapper *, const QString& name, const QString& input,
                 const QString& inputOptions, const QString& output,
                 bool _enable, VLMDialog *parent, int _type = QVLM_Broadcast );
+    virtual ~VLMAWidget() = default;
     virtual void update() = 0;
 protected:
     QLabel *nameLabel;


=====================================
modules/gui/qt/maininterface/compositor.hpp
=====================================
@@ -94,6 +94,7 @@ public:
     class QmlUISurface
     {
     public:
+        virtual ~QmlUISurface() = default;
         virtual QQmlEngine* engine() const = 0;
         virtual void setContent(QQmlComponent *component, QQuickItem *item) = 0;
 


=====================================
modules/gui/qt/medialibrary/medialib.hpp
=====================================
@@ -218,6 +218,7 @@ class RunOnMLThreadBaseRunner : public QObject, public QRunnable
 {
     Q_OBJECT
 public:
+    virtual ~RunOnMLThreadBaseRunner() = default;
     virtual void runUICallback() = 0;
     virtual void cancel() = 0;
 signals:


=====================================
modules/gui/qt/medialibrary/mlfoldersmodel.hpp
=====================================
@@ -55,6 +55,7 @@ public:
     };
 
     MLFoldersBaseModel( QObject *parent = nullptr );
+    virtual ~MLFoldersBaseModel() = default;
 
     void setCtx(MainCtx* ctx);
     inline MainCtx* getCtx() { return m_ctx; }


=====================================
modules/gui/qt/util/asynctask.hpp
=====================================
@@ -150,6 +150,8 @@ template <typename T>
 class AsyncTask : public BaseAsyncTask
 {
 public:
+    virtual ~AsyncTask() = default;
+
     virtual T execute() = 0;
 
     /**


=====================================
modules/gui/qt/util/selectable_list_model.hpp
=====================================
@@ -32,6 +32,8 @@ public:
     SelectableListModel(QObject *parent = nullptr) :
         QAbstractListModel(parent) {}
 
+    virtual ~SelectableListModel() = default;
+
     Q_INVOKABLE bool isSelected(int index) const;
     Q_INVOKABLE void setSelected(int index, bool selected);
     Q_INVOKABLE void toggleSelected(int index);



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/7e47fa5242df547f924b0a140286b3d90caf65a7

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/7e47fa5242df547f924b0a140286b3d90caf65a7
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance