[vlc-commits] [Git][videolan/vlc][3.0.x] Set extra version number when building MSI

[Rémi Denis-Courmont (@Courmisch)]

Rémi Denis-Courmont pushed to branch 3.0.x at VideoLAN / VLC


Commits:
41d862cc by Kaleb Luedtke at 2022-05-03T16:36:35+00:00
Set extra version number when building MSI

* Use the @VERSION_EXTRA@ which is used in the exe build in place of the
  static '0'
* Change the Display Name in appwiz.cpl to be just the product name,
  matching the exe build

(cherry picked from commit cafda6718082ab655f23b88a6a94dac747c57a19)

Signed-off-by: Steve Lhomme <robux4 at ycbcr.xyz>

- - - - -


2 changed files:

- extras/package/win32/msi/config.wxi.in
- extras/package/win32/msi/product.wxs


Changes:

=====================================
extras/package/win32/msi/config.wxi.in
=====================================
@@ -10,8 +10,9 @@
     <?define VerMajor = "@VERSION_MAJOR@" ?>
     <?define VerMinor = "@VERSION_MINOR@" ?>
     <?define VerPatch = "@VERSION_REVISION@" ?>
+    <?define VerExtra = "@VERSION_EXTRA@" ?>
     <?define Version = "$(var.VerMajor).$(var.VerMinor).$(var.VerPatch)" ?>
-    <?define VersionLong = "$(var.Version).0" ?>
+    <?define VersionLong = "$(var.Version).$(var.VerExtra)" ?>
 
     <?define SourceDir = "vlc- at VERSION@" ?>
     <!--<?define PluginsPath = "$(var.BinPath)\plugins" ?>


=====================================
extras/package/win32/msi/product.wxs
=====================================
@@ -25,7 +25,7 @@
      xmlns:util="http://schemas.microsoft.com/wix/UtilExtension">
     <Product
         Id='*'
-        Name='$(var.ProductName) $(var.Version) ($(var.PlatformString))'
+        Name='$(var.ProductName)'
         Language='1033'
         Version='$(var.VersionLong)'
         Manufacturer='$(var.Manufacturer)'
@@ -408,5 +408,3 @@
     <ProgressText Action="RegisterAxvlc">Registering DirectX plugin...</ProgressText>
     <ProgressText Action="UnregisterAxvlc">Removing DirectX plugin...</ProgressText>
 -->
-
-



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/41d862cc26195ebc05f9a0f53e6a3f184b52ce4b

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/41d862cc26195ebc05f9a0f53e6a3f184b52ce4b
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance