[vlc-commits] [Git][videolan/vlc][master] 2 commits: trace: change render arguments order

[Rémi Denis-Courmont (@Courmisch)]

Rémi Denis-Courmont pushed to branch master at VideoLAN / VLC


Commits:
c9eb4194 by Thomas Guillem at 2022-05-07T07:45:14+00:00
trace: change render arguments order

Use the same order than the clock API (system, then pts).

- - - - -
ad4cb3ac by Thomas Guillem at 2022-05-07T07:45:14+00:00
tracer: don't print render special values

0 and INT64_MAX make the graph difficult to scale.

- - - - -


2 changed files:

- include/vlc_tracer.h
- src/clock/clock.c


Changes:

=====================================
include/vlc_tracer.h
=====================================
@@ -165,11 +165,16 @@ static inline void vlc_tracer_TraceStreamDTS(struct vlc_tracer *tracer, const ch
 }
 
 static inline void vlc_tracer_TraceRender(struct vlc_tracer *tracer, const char *type,
-                                const char *id, vlc_tick_t pts, vlc_tick_t now)
+                                const char *id, vlc_tick_t now, vlc_tick_t pts)
 {
-    vlc_tracer_Trace(tracer, VLC_TRACE("type", type), VLC_TRACE("id", id),
-                     VLC_TRACE("pts", NS_FROM_VLC_TICK(pts)),
-                     VLC_TRACE("render_ts", NS_FROM_VLC_TICK(now)), VLC_TRACE_END);
+    if (now != VLC_TICK_MAX && now != VLC_TICK_INVALID)
+        vlc_tracer_Trace(tracer, VLC_TRACE("type", type), VLC_TRACE("id", id),
+                         VLC_TRACE("pts", NS_FROM_VLC_TICK(pts)),
+                         VLC_TRACE("render_ts", NS_FROM_VLC_TICK(now)), VLC_TRACE_END);
+    else
+        vlc_tracer_Trace(tracer, VLC_TRACE("type", type), VLC_TRACE("id", id),
+                         VLC_TRACE("pts", NS_FROM_VLC_TICK(pts)),
+                         VLC_TRACE_END);
 }
 
 static inline void vlc_tracer_TraceEvent(struct vlc_tracer *tracer, const char *type,


=====================================
src/clock/clock.c
=====================================
@@ -114,9 +114,8 @@ static inline void vlc_clock_on_update(vlc_clock_t *clock,
                               clock->cbs_data);
 
     if (main_clock->tracer != NULL && clock->track_str_id)
-    {
-        vlc_tracer_TraceRender(main_clock->tracer, "RENDER", clock->track_str_id, ts, system_now);
-    }
+        vlc_tracer_TraceRender(main_clock->tracer, "RENDER", clock->track_str_id,
+                               system_now, ts);
 }
 
 static vlc_tick_t vlc_clock_master_update(vlc_clock_t *clock,



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/aeb120a889fe12f4636fe470bbc25b0fbc53a4d5...ad4cb3ac56d35de24edad0ba88db7e6910abeb61

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/aeb120a889fe12f4636fe470bbc25b0fbc53a4d5...ad4cb3ac56d35de24edad0ba88db7e6910abeb61
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance