[vlc-commits] [Git][videolan/vlc][master] placebo: remove redundant test

[Rémi Denis-Courmont (@Courmisch)]

Rémi Denis-Courmont pushed to branch master at VideoLAN / VLC


Commits:
3e44f9c9 by Rémi Denis-Courmont at 2022-05-10T16:11:27+00:00
placebo: remove redundant test

Window can no longer be NULL here.

- - - - -


1 changed file:

- modules/video_output/libplacebo/display.c


Changes:

=====================================
modules/video_output/libplacebo/display.c
=====================================
@@ -113,17 +113,11 @@ static int Open(vout_display_t *vd,
     if (unlikely(sys == NULL))
         return VLC_ENOMEM;
 
-    if (vd->cfg->window == NULL)
-    {
-        msg_Err(vd, "parent window not available");
-        goto error;
-    }
-
     char *name = var_InheritString(vd, "pl-gpu");
     sys->pl = vlc_placebo_Create(vd->cfg, name);
     free(name);
     if (sys->pl == NULL)
-        goto error;
+        return VLC_EGENERIC;
 
     if (vlc_placebo_MakeCurrent(sys->pl) != VLC_SUCCESS)
         goto error;
@@ -189,8 +183,7 @@ static int Open(vout_display_t *vd,
 
 error:
     pl_renderer_destroy(&sys->renderer);
-    if (sys->pl != NULL)
-        vlc_placebo_Release(sys->pl);
+    vlc_placebo_Release(sys->pl);
     return VLC_EGENERIC;
 }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/3e44f9c9d0ddb142aedd480317ef59df9eb7012c

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/3e44f9c9d0ddb142aedd480317ef59df9eb7012c
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance