[vlc-commits] [Git][videolan/vlc][master] 3 commits: qt: preferences_widgets: add missing override

[Hugo Beauzée-Luyssen (@chouquette)]

Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC


Commits:
b7637294 by Alexandre Janniaux at 2022-05-21T13:51:13+00:00
qt: preferences_widgets: add missing override

- - - - -
8d838e7e by Alexandre Janniaux at 2022-05-21T13:51:13+00:00
qt: preferences_widgets: use override

... instead of Q_DECL_OVERRIDE, since it always expand to override for
>=C++11 configuration, and the module uses C++11 anyway.

- - - - -
d305611d by Alexandre Janniaux at 2022-05-21T13:51:13+00:00
qt: medialib: add missing override

- - - - -


2 changed files:

- modules/gui/qt/dialogs/preferences/preferences_widgets.hpp
- modules/gui/qt/medialibrary/medialib.hpp


Changes:

=====================================
modules/gui/qt/dialogs/preferences/preferences_widgets.hpp
=====================================
@@ -112,8 +112,8 @@ class VIntConfigControl : public ConfigControl
     Q_OBJECT
 public:
     virtual int getValue() const = 0;
-    virtual void doApply() Q_DECL_OVERRIDE;
-    virtual void storeValue() Q_DECL_OVERRIDE;
+    virtual void doApply() override;
+    virtual void storeValue() override;
 protected:
     VIntConfigControl( module_config_t *i ) : ConfigControl(i) {}
 };
@@ -223,8 +223,8 @@ class VFloatConfigControl : public ConfigControl
     Q_OBJECT
 public:
     virtual float getValue() const = 0;
-    void doApply() Q_DECL_OVERRIDE;
-    void storeValue() Q_DECL_OVERRIDE;
+    void doApply() override;
+    void storeValue() override;
 protected:
     VFloatConfigControl( module_config_t *i ) : ConfigControl(i) {}
 };
@@ -266,8 +266,8 @@ class VStringConfigControl : public ConfigControl
     Q_OBJECT
 public:
     virtual QString getValue() const = 0;
-    void doApply() Q_DECL_OVERRIDE;
-    void storeValue() Q_DECL_OVERRIDE;
+    void doApply() override;
+    void storeValue() override;
 protected:
     VStringConfigControl( module_config_t *i ) : ConfigControl(i) {}
 };
@@ -422,7 +422,7 @@ public:
     KeySelectorControl( QWidget * );
     void insertInto( QGridLayout*, int row = 0 ) Q_DECL_OVERRIDE;
     void doApply() Q_DECL_OVERRIDE;
-    void storeValue() {};
+    void storeValue() override {};
     enum ColumnIndex
     {
         ACTION_COL = 0,


=====================================
modules/gui/qt/medialibrary/medialib.hpp
=====================================
@@ -245,7 +245,7 @@ public:
         setAutoDelete(false);
     }
 
-    void run()
+    void run() override
     {
         if (m_canceled)
         {



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/a0186adb8e2a0dbd3eda6ee4ff38dbd9d1ff8604...d305611d6d88ce5038bf916348fdd6ebcb021fb0

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/a0186adb8e2a0dbd3eda6ee4ff38dbd9d1ff8604...d305611d6d88ce5038bf916348fdd6ebcb021fb0
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance